From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 067C21FF144 for ; Tue, 24 Mar 2026 14:42:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7A8D1234B; Tue, 24 Mar 2026 14:42:50 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Tue, 24 Mar 2026 14:42:16 +0100 Message-Id: From: "Dominik Rusovac" To: "Proxmox VE development discussion" Cc: "pve-devel" Subject: Re: [pve-devel] [PATCH SERIES docs/ha-manager/manager v3] close #6144: add ui button + api for node maintenance mode Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.20.0 References: <20251025183814.698627-1-thomas@atskinner.net> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774359689469 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.339 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: R6ETK3QBYJIW7ZXMNLDN4QRIVLJYMOAY X-Message-ID-Hash: R6ETK3QBYJIW7ZXMNLDN4QRIVLJYMOAY X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Jan 26, 2026 at 2:09 AM CET, Thomas Skinner wrote: > On Mon, Dec 22, 2025 at 8:09=E2=80=AFAM Thomas Skinner wrote: >> >> On Sat, Oct 25, 2025 at 1:38=E2=80=AFPM Thomas Skinner wrote: >> > >> > Continued work on node maintenance mode button in UI. >> > >> > Changes since V2: >> > - Adjust permissions from Sys.Console to Sys.Modify >> > - Fix typo in description >> > >> > docs: >> > >> > Thomas Skinner (1): >> > add docs for maintenance mode buttons in UI >> > >> > ha-manager.adoc | 22 ++++++++++++++++++++-- >> > 1 file changed, 20 insertions(+), 2 deletions(-) >> > >> > >> > ha-manager: >> > >> > Thomas Skinner (1): >> > add additional api field for lrm_mode in status check >> > >> > src/PVE/API2/HA/Status.pm | 7 +++++++ >> > 1 file changed, 7 insertions(+) >> > >> > >> > manager: >> > >> > Thomas Skinner (2): >> > add api setter for node maintenance mode >> > add UI for node maintenance enable/disable >> > >> > PVE/API2/Nodes.pm | 38 +++++++++++++++ >> > www/manager6/ha/StatusView.js | 92 ++++++++++++++++++++++++++++++++++= + >> > 2 files changed, 130 insertions(+) >> > >> > >> > -- >> > 2.47.3 >> > >> >> Hello! Any updates on getting this patch series accepted? > > Hello! Checking in again to see if this patch series can be applied. > Hello Thomas, thank you for sending this patch series! We plan to extend the concept of node maintenance to non-HA resources in the near future. This will involve a dedicated endpoint and corresponding UI support. To avoid "programming us into a corner" or causing code churn, we would like to evaluate some approaches first, before committing anything. We'll then retake a look at your changes here and try to build on top of them. I hope that's okay with you. Kind regards, Dominik [snip]