From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id DC89F1FF136
	for <inbox@lore.proxmox.com>; Mon, 23 Mar 2026 14:04:43 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 11D8318878;
	Mon, 23 Mar 2026 14:05:03 +0100 (CET)
Content-Type: text/plain; charset=UTF-8
Date: Mon, 23 Mar 2026 14:04:27 +0100
Message-Id: <DHA6LNRPPBCI.1CGP6XOKE01HH@proxmox.com>
Subject: Re: [PATCH ha-manager v2 3/4] fix #2751: implement disarm-ha and
 arm-ha for safe cluster maintenance
From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
 <pve-devel@lists.proxmox.com>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Mailer: aerc 0.20.0
References: <20260321234350.2158438-1-t.lamprecht@proxmox.com>
 <20260321234350.2158438-4-t.lamprecht@proxmox.com>
In-Reply-To: <20260321234350.2158438-4-t.lamprecht@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1774271021272
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.352 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: CCTUD3CDRKIDYBO6AEX2WXRG5CRDSUOA
X-Message-ID-Hash: CCTUD3CDRKIDYBO6AEX2WXRG5CRDSUOA
X-MailFrom: d.rusovac@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

two negligible nits inline

On Sun Mar 22, 2026 at 12:42 AM CET, Thomas Lamprecht wrote:

[snip]

> diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm
> index 301c391..f6857bd 100644
> --- a/src/PVE/HA/Sim/Hardware.pm
> +++ b/src/PVE/HA/Sim/Hardware.pm
> @@ -835,6 +835,15 @@ sub sim_hardware_cmd {
>                  || $action eq 'disable-node-maintenance'
>              ) {
>                  $self->queue_crm_commands_nolock("$action $node");
> +            } elsif ($action eq 'disarm-ha') {
> +                my $mode =3D $params[0];
> +
> +                die "sim_hardware_cmd: unknown resource mode '$mode'\n"
> +                    if $mode !~ m/^(freeze|ignore)$/;
> +
> +                $self->queue_crm_commands_nolock("disarm-ha $mode");

    $self->queue_crm_commands_nolock("$action $mode");

nit: following DRY principle, this would be cleaner imo

> +            } elsif ($action eq 'arm-ha') {
> +                $self->queue_crm_commands_nolock("arm-ha");

    $self->queue_crm_commands_nolock("$action");

nit: same here

[snip]