From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E87811FF136 for ; Mon, 23 Mar 2026 13:27:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A1EDF16614; Mon, 23 Mar 2026 13:26:59 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Mon, 23 Mar 2026 13:26:25 +0100 Message-Id: Subject: Re: [PATCH proxmox-widget-toolkit 2/2] notifications: Add opt-in OAuth2 support for SMTP targets From: "Lukas Wagner" To: "Arthur Bied-Charreton" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260213160415.609868-1-a.bied-charreton@proxmox.com> <20260213160415.609868-11-a.bied-charreton@proxmox.com> In-Reply-To: <20260213160415.609868-11-a.bied-charreton@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774268739857 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GIZWUZIBLHHHZ3ZKOKFGWXRA4IJSW34B X-Message-ID-Hash: GIZWUZIBLHHHZ3ZKOKFGWXRA4IJSW34B X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Feb 13, 2026 at 5:04 PM CET, Arthur Bied-Charreton wrote: > Add Google & Microsoft OAuth2 authentication methods to SMTP endpoint > config. > The enableOAuth2 pmxSmtpEditPanel config flag allows consumers to opt > into the new feature, so it can be gradually introduced into services. > > When disabled, no changes are visible from the UI, and only 'None' and > 'Username/Password' are shown as > authentication methods. The flag is passed from the schema config, as it > is done for defaultMailAuthor. > > Signed-off-by: Arthur Bied-Charreton Some notes: - same as the other patch, this seems to be missing a `make tidy` - when adding a new endpoint, after successful authorization, it would be nice to get visual feedback in the dialog. Maybe something like a green checkmark and "Authorized" in the UI next to the button? - when editing an existing OAUTH SMTP endpoint, the "Client Secret" field is marked invalid because it does not contain any text, also making it impossible to change anything else in this endpoint. This should handled similarly to how we handle the regular password field: Only require a value if isCreate is true, and use a "Unchanged" empty text otherwise. - Not 100% sure, but from my understanding the term "Authorize" would be more fitting then "Authenticate"