From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E0F821FF13C for ; Thu, 19 Mar 2026 11:56:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5F711AC3D; Thu, 19 Mar 2026 11:56:39 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Mar 2026 11:56:04 +0100 Message-Id: To: =?utf-8?q?Roman_Ondr=C3=A1=C4=8Dek?= , From: "Max R. Carrara" Subject: Re: [PATCH pve-storage v2 0/1] storage: add xz support X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20260308175536.612599-1-mail@romanondracek.cz> In-Reply-To: <20260308175536.612599-1-mail@romanondracek.cz> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773917721616 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.086 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3TV3HK6ICQR3LSUIPT7WANRRN3ZNOI4Q X-Message-ID-Hash: 3TV3HK6ICQR3LSUIPT7WANRRN3ZNOI4Q X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun Mar 8, 2026 at 6:55 PM CET, Roman Ondr=C3=A1=C4=8Dek wrote: > A popular ISO compressed exclusively with xz is FreeBSD [1]. > > Since this requires adding `xz` to the list of known compression > formats we add decompression methods for vmz and tar. > > [1] https://download.freebsd.org/releases/amd64/amd64/ISO-IMAGES/15.0/ > > Signed-off-by: Roman Ondr=C3=A1=C4=8Dek Hello again! Thanks for your patches -- do you mind if I integrate them as part of another set of changes that I'm currently working on? Since I'm touching a lot of the surrounding code at the moment, it would need a lot of rebasing on either of our sides. You'd obviously still be accredited with adding support for xz in the form of an Originally-by trailer in the corresponding git commit messages. If that's fine with you then no additional work should be needed on your side -- otherwise I'll give this a more thorough look and see if we can merge this before any of my changes land. > > Roman Ondr=C3=A1=C4=8Dek (1): > storage: add xz support > > debian/control | 1 + > src/PVE/Storage.pm | 3 +++ > src/PVE/Storage/Plugin.pm | 2 +- > src/test/archive_info_test.pm | 6 ++++-- > src/test/list_volumes_test.pm | 11 ++++++++++- > src/test/parse_volname_test.pm | 8 ++++---- > src/test/path_to_volume_id_test.pm | 12 +++++++----- > 7 files changed, 30 insertions(+), 13 deletions(-)