From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EDDAF1FF13C for ; Thu, 19 Mar 2026 11:05:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 86A4018E61; Thu, 19 Mar 2026 11:06:11 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Mar 2026 11:05:37 +0100 Message-Id: To: "Arthur Bied-Charreton" Subject: Re: [PATCH] fix #7337: Keep track of deep link on OpenID login X-Mailer: aerc 0.20.0 References: <20260312143032.409115-1-a.bied-charreton@proxmox.com> In-Reply-To: <20260312143032.409115-1-a.bied-charreton@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773914694653 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.944 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2B7PSPCYJSF247YBA4L65GDARVYSQBKA X-Message-ID-Hash: 2B7PSPCYJSF247YBA4L65GDARVYSQBKA X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Mar 12, 2026 at 3:30 PM CET, Arthur Bied-Charreton wrote: > Previously, when opening a deep link without being logged into PBS, the > hash was getting lost, redirecting the user to #pbsDashboard instead of > /#. > > Store `window.location.hash` in sessionStorage (per-tab storage) before > redirecting to the login URL, and add it to the history after successful > login to direct the user to the deeplink they opened. > > `#pbsDashboard` remains the default redirect if no deeplink is stored. > > Signed-off-by: Arthur Bied-Charreton > --- > www/LoginView.js | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/www/LoginView.js b/www/LoginView.js > index fd9594f6..b72e4223 100644 > --- a/www/LoginView.js > +++ b/www/LoginView.js > @@ -48,6 +48,7 @@ Ext.define('PBS.LoginView', { > > if (this.getViewModel().data.openid =3D=3D=3D true) { > const redirectURL =3D location.origin; > + sessionStorage.setItem('openid-deeplink', location.hash)= ; nit: i think it would be nicer if this was prefixed, so something like "pbs-openid-deeplink". also quickly grep-ing over the widget toolkit and pbs ui directory, it seems that for local storage we tend to prefer camel case, though that isn't consistent. > try { > let resp =3D await Proxmox.Async.api2({ > url: '/api2/extjs/access/openid/auth-url', > @@ -217,7 +218,13 @@ Ext.define('PBS.LoginView', { > let creds =3D response.result.data; > PBS.Utils.updateLoginData(creds); > PBS.app.changeView('mainview'); > - history.replaceState(null, '', `${redire= ctURL}#pbsDashboard`); > + let deeplink =3D sessionStorage.getItem(= 'openid-deeplink'); > + if (deeplink) { > + sessionStorage.removeItem('openid-de= eplink'); > + history.replaceState(null, '', `${re= directURL}${deeplink}`); > + } else { > + history.replaceState(null, '', `${re= directURL}#pbsDashboard`); > + } > }, > }); > } other than the small nit above, this looks good to me so consider this: Reviewed-by: Shannon Sterz