From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1AF541FF138 for ; Wed, 04 Mar 2026 08:57:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CBBEF2128; Wed, 4 Mar 2026 08:58:27 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 04 Mar 2026 08:58:20 +0100 Message-Id: Subject: Re: [PATCH ha-manager v2] resources: Expand max_restart option From: "Daniel Kral" To: "Thomas Lamprecht" , "Maximiliano Sandoval" , X-Mailer: aerc 0.21.0-38-g7088c3642f2c-dirty References: <20260303132206.222398-1-m.sandoval@proxmox.com> <65bac8ca-7d95-47fd-83d0-3af5ee22c77b@proxmox.com> In-Reply-To: <65bac8ca-7d95-47fd-83d0-3af5ee22c77b@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772611075427 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.668 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.322 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1.141 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: G73ECGM2E6OA5OXKKKZQATEC2DAOLJ6C X-Message-ID-Hash: G73ECGM2E6OA5OXKKKZQATEC2DAOLJ6C X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Mar 3, 2026 at 9:09 PM CET, Thomas Lamprecht wrote: > Am 03.03.26 um 14:22 schrieb Maximiliano Sandoval: >> When read next to `max_relocate` it is not clear which happens first >> after a service fails to start. >>=20 >> Signed-off-by: Maximiliano Sandoval >>=20 >> --- >>=20 >> Differences from v1: >> - Incorporate feedback. Namely, "the service will be attempted to be re= located" >> was a bit too convoluted. >>=20 >> src/PVE/HA/Resources.pm | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >>=20 >> diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm >> index 68d9d16..404f6dc 100644 >> --- a/src/PVE/HA/Resources.pm >> +++ b/src/PVE/HA/Resources.pm >> @@ -73,7 +73,8 @@ EODESC >> }, >> max_restart =3D> { >> description =3D> "Maximal number of tries to restart the se= rvice on" >> - . " a node after its start failed.", >> + . " a node after its start failed. When reached, the HA= manager will try to" >> + . " relocate the service to an eligible node.", > > > IIRC we decided to try using the term "resources" for the VM/CTs managed = by HA > and "services" more for the daemons for new docs/description (and Someday= =E2=84=A2 clean > up the existing usage). Can be easily fixed up on applying, just wanted t= o ensure > I did not misremember (CCing also Dano for that) +1, in descriptions I'd also tend to go for "HA resource" to make sure the term differentiates itself from "cluster resource" or other kinds of resources, where it makes sense and doesn't bloat the message length too much. s/service/HA resource/ should be done for max_relocate here as well, maybe in a patch before that. > >> type =3D> 'integer', >> optional =3D> 1, >> default =3D> 1,