From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CB06A1FF137 for ; Tue, 03 Mar 2026 17:45:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0E8101D92A; Tue, 3 Mar 2026 17:46:52 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 03 Mar 2026 17:46:47 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Maximiliano Sandoval" , Subject: Re: [PATCH ha-manager v2] resources: Expand max_restart option X-Mailer: aerc 0.21.0 References: <20260303132206.222398-1-m.sandoval@proxmox.com> In-Reply-To: <20260303132206.222398-1-m.sandoval@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772556382707 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.66 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.968 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.495 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Y46QQLBIKE2OJC4ZYP74OSOPLXUPR4CG X-Message-ID-Hash: Y46QQLBIKE2OJC4ZYP74OSOPLXUPR4CG X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I prefer this one over v1 because I think it's more comprehensible. lgtm Reviewed-by: Michael K=C3=B6ppl On Tue Mar 3, 2026 at 2:22 PM CET, Maximiliano Sandoval wrote: > When read next to `max_relocate` it is not clear which happens first > after a service fails to start. > > Signed-off-by: Maximiliano Sandoval > > --- > > Differences from v1: > - Incorporate feedback. Namely, "the service will be attempted to be rel= ocated" > was a bit too convoluted. > > src/PVE/HA/Resources.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm > index 68d9d16..404f6dc 100644 > --- a/src/PVE/HA/Resources.pm > +++ b/src/PVE/HA/Resources.pm > @@ -73,7 +73,8 @@ EODESC > }, > max_restart =3D> { > description =3D> "Maximal number of tries to restart the ser= vice on" > - . " a node after its start failed.", > + . " a node after its start failed. When reached, the HA = manager will try to" > + . " relocate the service to an eligible node.", > type =3D> 'integer', > optional =3D> 1, > default =3D> 1,