From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 658A51FF137 for ; Tue, 03 Mar 2026 08:37:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DA667CCEC; Tue, 3 Mar 2026 08:38:42 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 03 Mar 2026 08:38:09 +0100 Message-Id: Subject: Re: [PATCH datacenter-manager v2 0/2] improvements for ParallelFetcher From: "Lukas Wagner" To: "Lukas Sichert" , "Lukas Wagner" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260206094304.117465-1-l.wagner@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772523464984 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.66 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.968 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.495 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7YEK5MWADVUPMDVBXAEMN25Q73UNYJQD X-Message-ID-Hash: 7YEK5MWADVUPMDVBXAEMN25Q73UNYJQD X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Lukas, thanks for testing/reviewing these changes. I'll post a v3 with some additional (minor) improvements and will include your R-b/T-b tags there. On Tue Feb 24, 2026 at 2:42 PM CET, Lukas Sichert wrote: > The changes were reviewed and tested in a cluster consisting of two > PVE nodes and one PBS. The following features were considered for testing= : > > Update handling: > The update summary could be retrieved without issues. > > Tasks: > The task log was displayed correctly. > > Only for the cluster: > SDN: > A Simple Zone and an EVPN Zone were created. > Both zones and the EVPN Controller were displayed correctly. > > Firewall: > Node firewall rules and datacenter firewall configuration were shown > correctly. > > The tests were also repeated with one of the nodes offline, and > everything still worked as expected. > > While reviewing the code, I noticed that the async fetchers currently > have no explicit timeouts. If one of the fetch operations blocks > indefinitely, it could stall the overall execution. Adding this in a > future commit would improve robustness. Very nice catch! I'll consider this for a future followup - although I'm not yet sure where the best place for adding a timeout mechanism would be, either right inside the parallel fetcher code, the individual handler fn's in the call sites, or directly in the PVE API bindings. > > Reviewed-by: Lukas Sichert > Tested-by: Lukas Sichert >