From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E49581FF13B for ; Wed, 25 Feb 2026 12:17:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95A3B35E01; Wed, 25 Feb 2026 12:18:24 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 25 Feb 2026 12:18:20 +0100 Message-Id: Subject: applied: [PATCH datacenter-manager] ui: views: add view id schema validation From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20251210151841.3617325-1-d.csapak@proxmox.com> In-Reply-To: <20251210151841.3617325-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772018283732 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.113 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.358 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.659 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YMFRTHNOGTDGSUFJZEFOLEIXVVA7JB5N X-Message-ID-Hash: YMFRTHNOGTDGSUFJZEFOLEIXVVA7JB5N X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Dec 10, 2025 at 4:18 PM CET, Dominik Csapak wrote: > so the user gets instant feedback about the validity of the id. > > Signed-off-by: Dominik Csapak > --- > ui/src/configuration/views.rs | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/ui/src/configuration/views.rs b/ui/src/configuration/views.r= s > index 810bda36..dcb0672c 100644 > --- a/ui/src/configuration/views.rs > +++ b/ui/src/configuration/views.rs > @@ -4,11 +4,12 @@ use std::rc::Rc; > =20 > use anyhow::{bail, Error}; > =20 > +use pdm_api_types::VIEW_ID_SCHEMA; > use yew::virtual_dom::{Key, VComp, VNode}; > =20 > use proxmox_yew_comp::form::delete_empty_values; > use proxmox_yew_comp::percent_encoding::percent_encode_component; > -use proxmox_yew_comp::{http_delete, http_get, http_post, http_put, EditW= indow}; > +use proxmox_yew_comp::{http_delete, http_get, http_post, http_put, EditW= indow, SchemaValidation}; > use proxmox_yew_comp::{ > LoadableComponent, LoadableComponentContext, LoadableComponentMaster= , > LoadableComponentScopeExt, LoadableComponentState, > @@ -341,7 +342,13 @@ fn input_panel(form_ctx: &FormContext, mode: InputPa= nelMode) -> Html { > =20 > match mode { > InputPanelMode::Create(store) =3D> { > - input_panel.add_field(tr!("Name"), Field::new().name("id").r= equired(true)); > + input_panel.add_field( > + tr!("Name"), > + Field::new() > + .name("id") > + .schema(&VIEW_ID_SCHEMA) > + .required(true), > + ); > input_panel.add_right_field( > tr!("Copy Layout from"), > ViewSelector::new(store) applied, thanks!