From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 513491FF13B for ; Wed, 25 Feb 2026 11:42:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 03248344B3; Wed, 25 Feb 2026 11:43:00 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Wed, 25 Feb 2026 11:42:24 +0100 Message-Id: From: "Daniel Kral" To: "Markus Frank" , Subject: Re: [PATCH guest-common v2 1/11] mapping: dir: add 'live-migration-method' parameter Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-38-g7088c3642f2c-dirty References: <20260223155951.468572-1-m.frank@proxmox.com> <20260223155951.468572-2-m.frank@proxmox.com> In-Reply-To: <20260223155951.468572-2-m.frank@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772016127460 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.113 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.358 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.659 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EBLEV4IND7XMPOLQCMMMHQHENN4VV372 X-Message-ID-Hash: EBLEV4IND7XMPOLQCMMMHQHENN4VV372 X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Feb 23, 2026 at 4:39 PM CET, Markus Frank wrote: > If a live migration method is selected, qemu-server starts virtiofsd > with the flags to enable live migration using the chosen method. > > Signed-off-by: Markus Frank > --- > src/PVE/Mapping/Dir.pm | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/src/PVE/Mapping/Dir.pm b/src/PVE/Mapping/Dir.pm > index 5ff02d1..a7d4c05 100644 > --- a/src/PVE/Mapping/Dir.pm > +++ b/src/PVE/Mapping/Dir.pm > @@ -74,6 +74,15 @@ my $defaultData =3D { > description =3D> "The ID of the directory mapping", > format =3D> 'pve-configid', > }, > + 'live-migration-method' =3D> { > + description =3D> "Allow live-migration when using the direct= ory with a virtiofs device." > + ." Ensure you are using the same shared directory on all= hosts." > + ." Available migration methods are 'file-handles' and 'f= ind-path'.", > + type =3D> 'string', > + optional =3D> 1, > + default =3D> 'file-handles', The default is off here, as an unset 'live-migration-method' disables the live migration for VMs that use that virtiofsd mapping. This should either be clarified as-is in the {verbose_,}description or a third enum such as 'none' could be introduced to expose that state explicitly. > + enum =3D> ['file-handles', 'find-paths'], > + }, > description =3D> { > type =3D> 'string', > description =3D> "Description of the directory mapping", > @@ -99,6 +108,7 @@ sub private { > sub options { > return { > description =3D> { optional =3D> 1 }, > + 'live-migration-method' =3D> { optional =3D> 1 }, > map =3D> {}, > }; > }