From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4B5321FF144 for ; Tue, 24 Feb 2026 16:13:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A16E8F454; Tue, 24 Feb 2026 16:14:19 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 24 Feb 2026 16:13:44 +0100 Message-Id: Subject: Re: [PATCH proxmox-widget-toolkit v2] fix #2685: ui: allow 4-bit mac_prefix suffix To: "Moayad Almalat" X-Mailer: aerc 0.20.0 References: <20260224120536.141228-1-m.almalat@proxmox.com> <1771937549.cj4v6qhgpi.astroid@yuna.none> <21c83baa-0e89-4b6f-a836-fa51ae795775@proxmox.com> In-Reply-To: <21c83baa-0e89-4b6f-a836-fa51ae795775@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771946009121 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.973 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.179 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.717 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.236 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OUTM67YX4MIPIYOV5SGR7DUQEWTXGBBY X-Message-ID-Hash: OUTM67YX4MIPIYOV5SGR7DUQEWTXGBBY X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Feb 24, 2026 at 3:29 PM CET, Moayad Almalat wrote: > Hi, > > Thank you! > > On 2/24/26 2:00 PM, Fabian Gr=C3=BCnbichler wrote: > > typo in the subject - a 4-bit prefix makes no sense =F0=9F=98=89 > In the subject I meant to say 4-bit suffix extension to mac_prefix. I > can send v3 if needed. > > > > On February 24, 2026 1:05 pm, Moayad Almalat wrote: > >> Signed-off-by: Moayad Almalat > >> --- > >> src/Toolkit.js | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/src/Toolkit.js b/src/Toolkit.js > >> index d4e579b..39513b8 100644 > >> --- a/src/Toolkit.js > >> +++ b/src/Toolkit.js > >> @@ -72,7 +72,7 @@ Ext.apply(Ext.form.field.VTypes, { > >> MacAddressText: gettext('Example') + ': 01:23:45:67:89:ab', > >> MacPrefix: function (v) { > >> - return /^[a-f0-9][02468ace](?::[a-f0-9]{2}){0,2}:?$/i.test(v= ); > >> + return > /^(?:[a-f0-9][02468ace](?::[a-f0-9]{2}){0,2}:?|[a-f0-9][02468ace](?::[a-f= 0-9]{2}){2}:[a-f0-9])$/i.test(v); > > > > I think this is not quite correct - the [02468ace] part here is for on= ly > > allowing unicast addresses, but that only applies to the first octet! > > > > the old regex allowed 1-3 octets (with the first octet always being > > restricted to not allow multicast), and you want to extend it to 4 > > octets AFAIU? that would simply require replacing the `{0,2}` with a > > `{0,3}`, I think? > > > > but note that the backend in PVE has the same checks and would need to > > be adapted as well.. > > > The unicast restrection applies only to the first octet, both > alternatives start at the beginning, so that part is unchanged. > > The intent is to allow a single extra hex nibble after 3 full octets > e.g., `BC:24:11:0` and I tested that in 3 LXC: > ``` > root@pve-a:/tmp# pct config 102 | grep hwaddr > ....hwaddr=3DBC:24:11:0E:0B:F3,ip=3Ddhcp,ip6=3Dauto,type=3Dveth > root@pve-a:/tmp# pct config 103 | grep hwaddr > ....hwaddr=3DBC:24:11:0A:DD:DD,ip=3Ddhcp,ip6=3Dauto,type=3Dveth > root@pve-a:/tmp# pct config 104 | grep hwaddr > ....hwaddr=3DBC:24:11:06:58:1C,ip=3Ddhcp,ip6=3Dauto,type=3Dveth > root@pve-a:/tmp# > ``` > the regex is more confusing than it needs to be tho. why not simply do the the following: /^[a-f0-9][02468ace](?::[a-f0-9]{2}){0,2}(?::[a-f0-9]?)?$/i this simply extends the existing regex with the additional prefix instead of duplicating most of the regex. also i think what fabian meant is, that this setting is also validated on the backend. so the regex will need to be adapted in `pve_verify_mac_prefix()` in `pve-cluster/src/PVE/DataCenterConfig.pm` for this to work as intended. please also adjust the commit message to something that reflects the intent better too. thanks! > >> }, > >> MacPrefixMask: /[a-fA-F0-9:]/, > >> MacPrefixText: > >> -- > >> 2.47.3 > >> > >> > >>