From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CD3521FF139 for ; Tue, 24 Feb 2026 12:16:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 12AB15DCD; Tue, 24 Feb 2026 12:17:45 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 24 Feb 2026 12:17:12 +0100 Message-Id: To: "Lukas Wagner" , Subject: Re: [PATCH datacenter-manager] cli: fix zsh shell completion definitions From: "Shan Shaji" X-Mailer: aerc 0.20.0 References: <20260224090205.15379-1-l.wagner@proxmox.com> In-Reply-To: <20260224090205.15379-1-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771931817307 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.956 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.179 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.717 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.236 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XZGHA6ZZAVNCA6WTN2C4ABMBFLGXJ5EQ X-Message-ID-Hash: XZGHA6ZZAVNCA6WTN2C4ABMBFLGXJ5EQ X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Applied and tested the changes. To test it, i have created a new user on my= VM with ZSH shell. Both `admin` and `client` CLI completions are working fine = now. Without the above change, the completions doesn't work and i was getting th= e following error: ``` _proxmox-datacenter-manager-admin:8: command not found: n ```=20 Tested-by: Shan Shaji On Tue Feb 24, 2026 at 10:02 AM CET, Lukas Wagner wrote: > To continue the `compadd` call on the next line, we need a literal \ > and then a newline (\n), meaning we need to first escape the \ and then > add the newline character. > > Signed-off-by: Lukas Wagner > --- > cli/completions/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cli/completions/Makefile b/cli/completions/Makefile > index 5eceaea7..5d2a814f 100644 > --- a/cli/completions/Makefile > +++ b/cli/completions/Makefile > @@ -20,7 +20,7 @@ _%: > @printf ' cmd=3D$${words[1]}\n' >>$@.tmp > @printf ' curr=3D$${words[cwords]}\n' >>$@.tmp > @printf ' prev=3D$${words[cwords-1]}\n' >>$@.tmp > - @printf ' compadd -- $$(COMP_CWORD=3D"$$cwords" COMP_LINE=3D"$$line"= COMP_POINT=3D"$$point" \\n' >>$@.tmp > + @printf ' compadd -- $$(COMP_CWORD=3D"$$cwords" COMP_LINE=3D"$$line"= COMP_POINT=3D"$$point" \\\n' >>$@.tmp > @printf ' $* bashcomplete "$$cmd" "$$curr" "$$prev")\n' >>$@.tmp > @printf '}\n' >>$@.tmp > mv $@.tmp $@