From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B98941FF136 for ; Mon, 23 Feb 2026 15:25:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04B82E616; Mon, 23 Feb 2026 15:26:50 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 23 Feb 2026 15:26:14 +0100 Message-Id: Subject: applied: [PATCH datacenter-manager 0/2] fix: cli: bash completions not working for CLI tools From: "Lukas Wagner" To: "Shan Shaji" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260206163519.218579-1-s.shaji@proxmox.com> In-Reply-To: <20260206163519.218579-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771856760469 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.798 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.79 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.547 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ODFHFNUENUN3DWGPVBVB4SV2D62HH2W4 X-Message-ID-Hash: ODFHFNUENUN3DWGPVBVB4SV2D62HH2W4 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Feb 6, 2026 at 5:35 PM CET, Shan Shaji wrote: > Shell completions for the CLIs were not working because the completion > files were installed with the `.bc` extension. > > According to the bash-completion documentation [1], completion files shou= ld > either use the `.bash` extension or no extension at all. Debian currently= ships > bash-completion 2.16 [2]. Since installing files without an extension is > planned to be deprecated in >=3D2.18, use the `.bash` extension for > compatibility with future versions. > > documentaion quote: >> The completion filename for command foo in this directory should be foo.= bash. >> Unsuffixed foo also works, but it is deprecated in >=3D 2.18. > > Passing the `bashcomplete` argument to proxmox-datacenter-api and > proxmox-datacenter-privileged-api results in an error instead of generati= ng > completions. Since these binaries are systemd-managed service executables > rather than user facing CLI tools, providing bash completion helpers migh= t not > be useful. Since i was not sure why we had completions for the same > i added it as another patch. Please correct me if i have missed anything.= =20 > > [1]- https://github.com/scop/bash-completion/blob/06547b33f6de3b6f8ba730f= 00e7f585297a31b4f/README.md?plain=3D1#L184 > [2]- https://packages.debian.org/en/trixie/bash-completion > applied, thank you! I squashed in a tiny change into the first commit - the `make clean` rule still cleaned the old .bc files, so I changed that to remove .bash files.