From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5CDD51FF13E for ; Fri, 20 Feb 2026 17:46:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A6056E39E; Fri, 20 Feb 2026 17:46:54 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Feb 2026 17:46:19 +0100 Message-Id: Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/7] fix #7192: properly enumerate PBS realms in 'Add Remote' wizard From: "Shan Shaji" To: "Shan Shaji" , "Proxmox Datacenter Manager development discussion" X-Mailer: aerc 0.20.0 References: <20251229134445.286401-1-l.wagner@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771605969202 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.106 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NEYB5E5O7IQR4CFG2YKHHFKLL3ZJZHVY X-Message-ID-Hash: NEYB5E5O7IQR4CFG2YKHHFKLL3ZJZHVY X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pdm-devel X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I have gone through the code and overall, i believe the code looks good as well. but a second review might also be nice. Reviewed-by: Shan Shaji On Fri Feb 20, 2026 at 4:17 PM CET, Shan Shaji wrote: > > Applied this series and tested the changes. > > ``` > Error: api error (status =3D 400: client error (Connect)) > ``` > > The above error doesn't appear anymore in the settings tab. I was able to > choose between the realms and add a backup server using `pbs` realm. > > Tested-by: Shan Shaji > > > On Mon Dec 29, 2025 at 2:44 PM CET, Lukas Wagner wrote: >> This fixes #7192 [1] by adding the needed API functions to enumerate >> remotes from PBS remotes. The the realm selector component is changed >> to support a realm-type property, based on which it selects the URL >> from which it requests the realms. >> >> This series also contains some minor renames in the UI code, as >> the old name `PveRealmSelector` did not make sense any more. >> >> [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=3D7192 >> >> >> proxmox-datacenter-manager: >> >> Lukas Wagner (7): >> pbs-client: add `list_domains` >> api: pbs: add /pbs/realms endpoint >> ui: rename pve_realm_selector module to remote_realm_selector >> ui: widgets: rename PveRealmSelector to RemoteRealmSelector >> ui: widgets: make RemoteRealmSelectorComp private >> ui: widget: remote realm selector: add missing docstrings >> ui: widgets: remote realm selector: support PBS remotes >> >> server/src/api/pbs/mod.rs | 55 +++++++++++++++++++ >> server/src/pbs_client.rs | 8 ++- >> ui/src/remotes/wizard_page_info.rs | 4 +- >> ui/src/widget/mod.rs | 4 +- >> ...m_selector.rs =3D> remote_realm_selector.rs} | 25 ++++++--- >> 5 files changed, 84 insertions(+), 12 deletions(-) >> rename ui/src/widget/{pve_realm_selector.rs =3D> remote_realm_selector.= rs} (84%) >> >> >> Summary over all repositories: >> 5 files changed, 84 insertions(+), 12 deletions(-)