From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 38EE11FF139 for ; Mon, 12 Jan 2026 11:31:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CDB1C1A8AB; Mon, 12 Jan 2026 11:31:06 +0100 (CET) Mime-Version: 1.0 Date: Mon, 12 Jan 2026 11:30:34 +0100 Message-Id: From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20251219123758.151318-1-s.sterz@proxmox.com> In-Reply-To: <20251219123758.151318-1-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768213791211 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/2] validate remote hostname X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Fri Dec 19, 2025 at 1:37 PM CET, Shannon Sterz wrote: > previously the endpoints list in the ui did not validate user input, > nor did the api when updating a remote. this could lead to an issue > where a user could configure a remote in a way that made it impossible > for pdm to connect to it. this series fixes that. > > changes since v1: > > * add validation to the correct place, thanks @ Dominik Csapak > > Shannon Sterz (2): > ui: node url list: validate list of endpoints > api types: node url: validate hostname > > lib/pdm-api-types/src/lib.rs | 3 +++ > lib/pdm-api-types/src/remotes.rs | 5 ++++- > ui/src/remotes/node_url_list.rs | 2 ++ > 3 files changed, 9 insertions(+), 1 deletion(-) > With the trivial fix mentioned in 1/2 locally: Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel