From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A7FE01FF183 for ; Wed, 17 Dec 2025 11:00:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9CF3E24352; Wed, 17 Dec 2025 11:01:39 +0100 (CET) Mime-Version: 1.0 Date: Wed, 17 Dec 2025 11:01:37 +0100 Message-Id: To: "Proxmox Datacenter Manager development discussion" From: "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20251216155253.378307-2-s.sterz@proxmox.com> In-Reply-To: <20251216155253.378307-2-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765965688217 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] applied: [PATCH datacenter-manager] ui: resource tree: name all columns and make them translatable X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Tue Dec 16, 2025 at 4:52 PM CET, Shannon Sterz wrote: > not giving a column a name leads to bad UX when editing the currently > visible columns of a table. the menu will then render a checkbox with > an empty label which may appear confusing. > > additionally, make all column headers of the table translatable. > > Signed-off-by: Shannon Sterz > --- > ui/src/widget/resource_tree.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ui/src/widget/resource_tree.rs b/ui/src/widget/resource_tree.rs > index c7d6e67..ba178b8 100644 > --- a/ui/src/widget/resource_tree.rs > +++ b/ui/src/widget/resource_tree.rs > @@ -414,7 +414,7 @@ fn columns( > .into() > }) > .into(), > - DataTableColumn::new("Node") > + DataTableColumn::new(tr!("Node")) > .width("150px") > .render(|item: &PdmTreeEntry| { > match item { > @@ -427,7 +427,7 @@ fn columns( > .into() > }) > .into(), > - DataTableColumn::new("") > + DataTableColumn::new(tr!("UI")) > .width("50px") > .justify("right") > .render({ applied, thanks! _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel