From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 949C11FF17C for ; Tue, 16 Dec 2025 14:57:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1266411110; Tue, 16 Dec 2025 14:58:31 +0100 (CET) Mime-Version: 1.0 Date: Tue, 16 Dec 2025 14:58:28 +0100 Message-Id: From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" , "Dominik Csapak" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20251210151841.3617325-1-d.csapak@proxmox.com> In-Reply-To: <20251210151841.3617325-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765893500235 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager] ui: views: add view id schema validation X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Wed Dec 10, 2025 at 4:18 PM CET, Dominik Csapak wrote: > so the user gets instant feedback about the validity of the id. > > Signed-off-by: Dominik Csapak > --- > ui/src/configuration/views.rs | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/ui/src/configuration/views.rs b/ui/src/configuration/views.rs > index 810bda36..dcb0672c 100644 > --- a/ui/src/configuration/views.rs > +++ b/ui/src/configuration/views.rs > @@ -4,11 +4,12 @@ use std::rc::Rc; > > use anyhow::{bail, Error}; > > +use pdm_api_types::VIEW_ID_SCHEMA; > use yew::virtual_dom::{Key, VComp, VNode}; > > use proxmox_yew_comp::form::delete_empty_values; > use proxmox_yew_comp::percent_encoding::percent_encode_component; > -use proxmox_yew_comp::{http_delete, http_get, http_post, http_put, EditWindow}; > +use proxmox_yew_comp::{http_delete, http_get, http_post, http_put, EditWindow, SchemaValidation}; > use proxmox_yew_comp::{ > LoadableComponent, LoadableComponentContext, LoadableComponentMaster, > LoadableComponentScopeExt, LoadableComponentState, > @@ -341,7 +342,13 @@ fn input_panel(form_ctx: &FormContext, mode: InputPanelMode) -> Html { > > match mode { > InputPanelMode::Create(store) => { > - input_panel.add_field(tr!("Name"), Field::new().name("id").required(true)); > + input_panel.add_field( > + tr!("Name"), > + Field::new() > + .name("id") > + .schema(&VIEW_ID_SCHEMA) > + .required(true), > + ); > input_panel.add_right_field( > tr!("Copy Layout from"), > ViewSelector::new(store) LGTM! Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel