From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 94A6D1FF17C
	for <inbox@lore.proxmox.com>; Tue, 16 Dec 2025 14:54:21 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id B911710E34;
	Tue, 16 Dec 2025 14:55:07 +0100 (CET)
Mime-Version: 1.0
Date: Tue, 16 Dec 2025 14:55:04 +0100
Message-Id: <DEZOXKU8TE4M.1DA9XQRNM1NZJ@proxmox.com>
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>
X-Mailer: aerc 0.21.0
References: <20251205112528.373387-1-c.heiss@proxmox.com>
 <20251205112528.373387-13-c.heiss@proxmox.com>
 <DETOUJX8CJOD.3AXSZCG6K3DND@proxmox.com>
In-Reply-To: <DETOUJX8CJOD.3AXSZCG6K3DND@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1765893296332
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.052 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pdm-devel] [PATCH datacenter-manager v2 12/14] ui:
 auto-installer: add installations overview panel
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Cc: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>

On Tue Dec 9, 2025 at 1:35 PM CET, Lukas Wagner wrote:
[..]
>> diff --git a/ui/src/main_menu.rs b/ui/src/main_menu.rs
>> index 18988ea..073b84d 100644
>> --- a/ui/src/main_menu.rs
>> +++ b/ui/src/main_menu.rs
>> @@ -378,6 +379,18 @@ impl Component for PdmMainMenu {
>>              remote_submenu,
>>          );
>>
>> +        let mut autoinstaller_submenu = Menu::new();
>> +
>> +        register_submenu(
>> +            &mut menu,
>> +            &mut content,
>> +            tr!("Automated Installations"),
>> +            "auto-installer",
>> +            Some("fa fa-cubes"),
>> +            |_| AutoInstallerPanel::default().into(),
>> +            autoinstaller_submenu,
>> +        );
>
> I'm not sure whether this should be a top-level menu - but then again,
> I'm not sure where it could go else. Maybe a tab under "Remotes"? Since
> any node that was automatically would realistically be added as a remote
> at some later time?

Yeah, bit hard. Given its two panels, not sure if we want to cram it
under Remotes somewhere. How could these two panels then be sensible
structured to not have two tabs (which would be kinda weird)?


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel