From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 87EA11FF184 for ; Thu, 4 Dec 2025 16:18:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 333963724; Thu, 4 Dec 2025 16:18:52 +0100 (CET) Mime-Version: 1.0 Date: Thu, 04 Dec 2025 16:18:49 +0100 Message-Id: From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" , "Dominik Csapak" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20251204142451.2992215-1-d.csapak@proxmox.com> <20251204142451.2992215-5-d.csapak@proxmox.com> In-Reply-To: <20251204142451.2992215-5-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764861483038 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 4/5] ui: views: add message on empty layouts X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Thu Dec 4, 2025 at 3:20 PM CET, Dominik Csapak wrote: > so users know better what to do. > > Signed-off-by: Dominik Csapak > --- > ui/src/dashboard/view/row_view.rs | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/ui/src/dashboard/view/row_view.rs b/ui/src/dashboard/view/row_view.rs > index e0b295c1..0571398c 100644 > --- a/ui/src/dashboard/view/row_view.rs > +++ b/ui/src/dashboard/view/row_view.rs > @@ -336,6 +336,19 @@ impl Component for RowViewComp { > .class("pwt-content-spacer-colors") > .class(css::FlexDirection::Row) > .class(css::FlexWrap::Wrap); > + > + if layout.is_empty() && !self.edit_mode { > + let icon = ""; > + let message = tr!("Layout is empty, you can add widgets in edit mode. You can enable editing with the '{0}' icon.", icon); > + let message = Html::from_html_unchecked(message.into()); > + row.add_child( > + Container::new() > + .flex(1.0) > + .padding(4) > + .class(css::TextAlign::Center) > + .with_child(message), > + ); > + } > for (row_idx, items) in layout.iter().enumerate() { > let flex_sum: f32 = items > .iter() I wonder, should we also show this message if the layout only contains *empty* rows? I accidentally had it in a state like this and was confused why I didn't see the message, since in non-edit mode they look the same. What do you think? Also, how about: "Layout is empty. Click the '{0} icon to to add widgets." I think this would be a bit more straight-to-the-point - but no hard feelings. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel