From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7230C1FF184 for ; Thu, 4 Dec 2025 09:23:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CC2B61B1B7; Thu, 4 Dec 2025 09:23:33 +0100 (CET) Mime-Version: 1.0 Date: Thu, 04 Dec 2025 09:22:59 +0100 Message-Id: To: "Shannon Sterz" X-Mailer: aerc 0.20.0 References: <20251203141552.336623-2-s.sterz@proxmox.com> In-Reply-To: <20251203141552.336623-2-s.sterz@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764836533348 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.092 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH yew-comp] pve: firewall: make the node enable option default to true X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" for reference, this got applied: https://git.proxmox.com/?p=ui/proxmox-yew-comp.git;a=commit;h=5a18df70ebb60c1f5f86d88ff0fff4c5a4a00fb6 On Wed Dec 3, 2025 at 3:15 PM CET, Shannon Sterz wrote: > otherwise the display in pdm will be inconsistent. > > Signed-off-by: Shannon Sterz > --- > src/configuration/pve/firewall_options_node_panel.rs | 2 +- > src/form/pve/firewall_property/mod.rs | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/configuration/pve/firewall_options_node_panel.rs b/src/configuration/pve/firewall_options_node_panel.rs > index b74bba1..4f5cb2b 100644 > --- a/src/configuration/pve/firewall_options_node_panel.rs > +++ b/src/configuration/pve/firewall_options_node_panel.rs > @@ -84,7 +84,7 @@ pub struct FirewallOptionsNodeComp { > > fn properties(mobile: bool) -> Vec { > vec![ > - firewall_property::enable_property(mobile), > + firewall_property::enable_node_property(mobile), > firewall_property::nosmurfs_property(mobile), > firewall_property::tcpflags_property(mobile), > firewall_property::ndp_property(mobile), > diff --git a/src/form/pve/firewall_property/mod.rs b/src/form/pve/firewall_property/mod.rs > index 38767d5..e14725b 100644 > --- a/src/form/pve/firewall_property/mod.rs > +++ b/src/form/pve/firewall_property/mod.rs > @@ -27,6 +27,10 @@ pub fn enable_property(mobile: bool) -> EditableProperty { > EditableProperty::new_bool("enable", tr!("Enable Firewall"), false, mobile).required(true) > } > > +pub fn enable_node_property(mobile: bool) -> EditableProperty { > + EditableProperty::new_bool("enable", tr!("Enable Firewall"), true, mobile).required(true) > +} > + > /// cluster wide enable firewall (stored as integer instead of bool) > pub fn cluster_enable_property(mobile: bool) -> EditableProperty { > EditableProperty::new_bool("enable", tr!("Enable Firewall"), false, mobile) _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel