From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8712D1FF178 for ; Mon, 1 Dec 2025 17:36:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE9FD2241B; Mon, 1 Dec 2025 17:36:35 +0100 (CET) Mime-Version: 1.0 Date: Mon, 01 Dec 2025 17:36:33 +0100 Message-Id: To: "Thomas Lamprecht" X-Mailer: aerc 0.20.0 References: <20251201102852.97396-1-s.sterz@proxmox.com> <20251201102852.97396-7-s.sterz@proxmox.com> In-Reply-To: From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764606950086 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.092 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH widget-toolkit v5 1/1] api viewer: add support for endpoints that are marked as unstable X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion , Thomas Lamprecht Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Mon Dec 1, 2025 at 5:26 PM CET, Thomas Lamprecht wrote: > Am 01.12.25 um 11:28 schrieb Shannon Sterz: >> display a warning when an endpoint is marked as unstable. >> >> Signed-off-by: Shannon Sterz >> Tested-by: Lukas Wagner >> Reviewed-by: Lukas Wagner >> --- >> src/api-viewer/APIViewer.js | 18 ++++++++++++++++-- >> 1 file changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/src/api-viewer/APIViewer.js b/src/api-viewer/APIViewer.js >> index 7f27e0d..1357741 100644 >> --- a/src/api-viewer/APIViewer.js >> +++ b/src/api-viewer/APIViewer.js >> @@ -210,7 +210,21 @@ Ext.onReady(function () { >> usage += cliUsageRenderer(method, endpoint); >> } >> >> - let sections = [ >> + let sections = []; >> + >> + if (info.unstable) { >> + sections.push({ >> + title: 'Unstable', >> + html: `
>> + >> + This API endpoint is marked as unstable. All information on this >> + page is subject to change, including input parameters, return values >> + and permissions. >> +
`, >> + }); >> + } >> + >> + sections.concat([ > > The concat [0] array method always returns a new array, so with your change > fully rolled out (installing this and then, e.g., rebuilding pve-docs with it) > the Description and Usage section vanished. I simply switched this out with doing > an sections.push, which modifies sections itself. > > [0]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/concat ah sorry missed that somehow, thanks for catching this. >> { >> title: 'Description', >> html: Ext.htmlEncode(info.description), >> @@ -221,7 +235,7 @@ Ext.onReady(function () { >> html: usage, >> bodyPadding: 10, >> }, >> - ]; >> + ]); >> >> if (info.parameters && info.parameters.properties) { >> let pstore = Ext.create('Ext.data.Store', { >> -- >> 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel