From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 747A21FF178 for ; Mon, 1 Dec 2025 15:54:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6BB051FECF; Mon, 1 Dec 2025 15:55:20 +0100 (CET) Mime-Version: 1.0 Date: Mon, 01 Dec 2025 15:55:16 +0100 Message-Id: To: "Lukas Wagner" X-Mailer: aerc 0.20.0 References: <20251201125859.237091-1-l.wagner@proxmox.com> In-Reply-To: <20251201125859.237091-1-l.wagner@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764600873156 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.092 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/4] system report via admin cli or API X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Mon Dec 1, 2025 at 1:58 PM CET, Lukas Wagner wrote: > Still missing the UI integration. > > Lukas Wagner (4): > server: add system report implementation > api: add system report API > cli: admin: add 'report' command to generate a system report > pdm-client: add bindings for system report generation > > cli/admin/src/main.rs | 13 +++ > lib/pdm-client/src/lib.rs | 10 ++ > server/src/api/nodes/mod.rs | 2 + > server/src/api/nodes/report.rs | 32 ++++++ > server/src/lib.rs | 1 + > server/src/report.rs | 195 +++++++++++++++++++++++++++++++++ > 6 files changed, 253 insertions(+) > create mode 100644 server/src/api/nodes/report.rs > create mode 100644 server/src/report.rs gave this a quick spin and looked through the code. as you mentioned in one of the code comments at least parts of this should live in proxmox-rs and share their implementation with proxmox-backup. however, that shouldn't hold this up for now and can be done as a follow up. left two minor comments on the first patch. also tested this by building the manager binary and using it in my test container. it worked as expected (some commands failed to this being a testing container). so consider this: Reviewed-by: Shannon Sterz Tested-by: Shannon Sterz _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel