From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BEE7A1FF184 for ; Thu, 20 Nov 2025 16:52:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C1242D33A; Thu, 20 Nov 2025 16:52:34 +0100 (CET) Date: Thu, 20 Nov 2025 16:52:00 +0100 Message-Id: Cc: "pdm-devel" From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Proxmox Datacenter Manager development discussion" Mime-Version: 1.0 X-Mailer: aerc 0.21.0 References: <20251120103620.128741-1-l.wagner@proxmox.com> <20251120103620.128741-4-l.wagner@proxmox.com> In-Reply-To: <20251120103620.128741-4-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763653889041 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [overview.rs, mod.rs] Subject: Re: [pdm-devel] [PATCH datacenter-manager 3/4] ui: pbs: move node overview to tab and add update tab X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" 1 nit inline On Thu Nov 20, 2025 at 11:36 AM CET, Lukas Wagner wrote: > PVE remote had an 'Updates' tab for a while now. This commit adds the > same thing for PBS remotes. > > Signed-off-by: Lukas Wagner > --- > ui/src/pbs/mod.rs | 4 +- > ui/src/pbs/node/mod.rs | 114 ++++++++++++++++++++++++++++++++++++ > ui/src/pbs/node/overview.rs | 11 +--- > 3 files changed, 118 insertions(+), 11 deletions(-) > > diff --git a/ui/src/pbs/mod.rs b/ui/src/pbs/mod.rs > index 1fdb417f..75ed9926 100644 > --- a/ui/src/pbs/mod.rs > +++ b/ui/src/pbs/mod.rs > @@ -24,11 +24,11 @@ pub use datastore::DatastorePanel; > mod namespace_selector; > > mod node; > -use node::overview::PbsNodeOverviewPanel; > > mod snapshot_list; > pub use snapshot_list::SnapshotList; > > +use crate::pbs::node::PbsNodePanel; > use crate::pbs::tree::PbsTree; > use crate::{get_deep_url, pdm_client}; > > @@ -108,7 +108,7 @@ impl LoadableComponent for PbsRemoteComp { > let props = ctx.props(); > > let content: Html = match &self.view { > - tree::PbsTreeNode::Root => PbsNodeOverviewPanel::new(props.remote.clone()).into(), > + tree::PbsTreeNode::Root => PbsNodePanel::new(props.remote.clone()).into(), > tree::PbsTreeNode::Datastore(data_store_config) => { > DatastorePanel::new(props.remote.clone(), data_store_config.clone()).into() > } > diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs > index 8468a02a..5cd210f8 100644 > --- a/ui/src/pbs/node/mod.rs > +++ b/ui/src/pbs/node/mod.rs > @@ -1 +1,115 @@ > +use std::rc::Rc; > + > +use proxmox_yew_comp::AptPackageManager; > +use yew::{ > + virtual_dom::{VComp, VNode}, > + Context, > +}; > + > +use pwt::{ > + css::{AlignItems, ColorScheme}, > + prelude::*, > + props::{ContainerBuilder, WidgetBuilder}, > + widget::{Fa, Row, TabBarItem, TabPanel}, > +}; > + > pub(crate) mod overview; > + > +use overview::PbsNodeOverviewPanel; > + > +use crate::get_deep_url_low_level; > + > +#[derive(Clone, Debug, Eq, PartialEq, Properties)] > +pub struct PbsNodePanel { > + /// The remote to show > + pub remote: String, > +} > + > +impl PbsNodePanel { > + pub fn new(remote: String) -> Self { > + yew::props!(Self { remote }) > + } > +} > + > +impl From for VNode { > + fn from(val: PbsNodePanel) -> Self { > + VComp::new::(Rc::new(val), None).into() > + } > +} > + > +struct PbsNodePanelComp; > + > +impl yew::Component for PbsNodePanelComp { > + type Message = (); > + type Properties = PbsNodePanel; > + > + fn create(_ctx: &yew::Context) -> Self { > + Self > + } > + > + fn changed(&mut self, ctx: &Context, old_props: &Self::Properties) -> bool { > + let props = ctx.props(); > + > + props.remote != old_props.remote > + } > + > + fn view(&self, ctx: &yew::Context) -> yew::Html { > + let props = ctx.props(); > + > + let title: Html = Row::new() > + .gap(2) > + .class(AlignItems::Baseline) > + .with_child(Fa::new("building")) > + .with_child(tr!("Node")) nit: I might not be entirely up-to-date on the nomenclature, but is "Node" correct here? IMO it also looked a bit off, having "Remote ''" on the left panel and then just "Node" on the right panel. Perhaps "Backup Server", "Proxmox Backup Server", or the name of the PBS might fit better in this case? Was there a reason to use "Node"? > + .into(); > + > + TabPanel::new() > + .class(pwt::css::FlexFit) _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel