From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B5A9F1FF17E for ; Thu, 13 Nov 2025 11:23:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A0E3D17893; Thu, 13 Nov 2025 11:23:58 +0100 (CET) Mime-Version: 1.0 Date: Thu, 13 Nov 2025 11:23:55 +0100 Message-Id: To: "Lukas Wagner" X-Mailer: aerc 0.20.0 References: <20251106143836.288888-1-s.sterz@proxmox.com> <20251106143836.288888-9-s.sterz@proxmox.com> In-Reply-To: From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763029410138 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 1/3] server/api-types: move AccessControlConfig to shared api types X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Thu Nov 13, 2025 at 11:15 AM CET, Lukas Wagner wrote: > On Thu Nov 6, 2025 at 3:38 PM CET, Shannon Sterz wrote: >> this doesn't really contain any information that is secret. moving it >> to the shared api types allows re-using it in the ui to check what >> privileges a user needs to access certain features. >> > > I'm not sure if pdm-api-types is the correct place for this, since it > does not really contain any... well... API types, as far as I can tell > :) > > Maybe this should be in `lib/pdm-ui-shared` or it's own small > micro-crate under `lib/`? What do you think? well my thinking was that we already define all privileges and roles here. keeping all of that in one place made sense to me, especially because roles and privileges aren't "types" in the traditional sense, but rather constants. so if we move that out, i'd like to move the roles and privileges etc. too. but i have no hard feelings on whether these stay here or get moved somewhere else and re-exported here. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel