From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 69E431FF17A for ; Tue, 11 Nov 2025 15:02:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B331CC3AA; Tue, 11 Nov 2025 15:03:45 +0100 (CET) Mime-Version: 1.0 Date: Tue, 11 Nov 2025 15:03:07 +0100 Message-Id: From: "Christoph Heiss" To: "Proxmox VE development discussion" X-Mailer: aerc 0.21.0 References: <20251030110627.812398-1-c.heiss@proxmox.com> In-Reply-To: <20251030110627.812398-1-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762869764350 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer v2 00/15] support network interface name pinning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" superseded by: https://lore.proxmox.com/pve-devel/20251111140014.1443471-1-c.heiss@proxmox.com/ On Thu Oct 30, 2025 at 12:06 PM CET, Christoph Heiss wrote: > This series adds support for pinning the names of network interfaces > directly during the installation, for all of GUI, TUI and auto-installer. > > There are also some smaller clean-ups and quality-of-life improvements > interspersed - to keep the patches for each part of the installer > together - in the series, which can also be applied > separately/beforehand if wanted. > > Tested all combinations, i.e. for each of GUI, TUI and auto-installer, > installed with pinning disabled (checking for regressions) and with > pinning enabled at some custom interface names set. > > The auto-installer changes can be tested by specifying e.g. > > [network.interface-name-pinning] > enabled = true > > [network.interface-name-pinning.mapping] > "ab:cd:ef:12:34:56" = "mgmt" > "12:34:56:ab:cd:ef" = "lan0" > > in the answer file. > > History > ======= > v1: https://lore.proxmox.com/pve-devel/20251014132207.1171073-1-c.heiss@proxmox.com/ > > Changes v1 -> v2: > * improved interface name validation according to our `pve-iface` json > schema > * fixed gui error dialog getting wrongly z-ordered > * implemented gtk machinery suggestion by Maximilano > > Diffstats > ========= > Christoph Heiss (14): > test: parse-kernel-cmdline: fix module import statement > run env: network: add kernel driver name to network interface info > common: utils: fix clippy warnings > common: setup: simplify network address list serialization > common: implement support for `network_interface_pin_map` config > auto: add support for pinning network interface names > assistant: verify network settings in `validate-answer` subcommand > post-hook: avoid redundant Option for (de-)serialization > post-hook: add network interface name and pinning status > tui: views: move network options view to own module > tui: views: form: allow attaching user-defined data to children > tui: add support for pinning network interface names > ui: gtk3: allow passing of dialog parent window > gui: add support for pinning network interface names > > Thomas Lamprecht (1): > install: add support for network interface name pinning > > Proxmox/Install.pm | 47 +- > Proxmox/Install/Config.pm | 8 + > Proxmox/Install/RunEnv.pm | 11 + > Proxmox/Sys/Net.pm | 63 ++- > Proxmox/UI.pm | 12 +- > Proxmox/UI/Gtk3.pm | 12 +- > proxinstall | 231 +++++++++- > proxmox-auto-install-assistant/src/main.rs | 3 +- > proxmox-auto-installer/src/answer.rs | 63 ++- > proxmox-auto-installer/src/utils.rs | 54 ++- > proxmox-auto-installer/tests/parse-answer.rs | 2 + > .../network_interface_pinning.json | 30 ++ > .../network_interface_pinning.toml | 22 + > ...n_from_dhcp_no_default_domain.run-env.json | 36 +- > ...rface_pinning_overlong_interface_name.json | 3 + > ...rface_pinning_overlong_interface_name.toml | 18 + > .../no_fqdn_from_dhcp.run-env.json | 36 +- > .../tests/resources/run-env-info.json | 38 +- > proxmox-installer-common/src/lib.rs | 5 + > proxmox-installer-common/src/options.rs | 219 ++++++++-- > proxmox-installer-common/src/setup.rs | 78 +++- > proxmox-installer-common/src/utils.rs | 6 +- > proxmox-post-hook/src/main.rs | 62 +-- > proxmox-tui-installer/src/main.rs | 105 +---- > proxmox-tui-installer/src/setup.rs | 3 + > proxmox-tui-installer/src/views/bootdisk.rs | 6 +- > proxmox-tui-installer/src/views/mod.rs | 41 +- > proxmox-tui-installer/src/views/network.rs | 406 ++++++++++++++++++ > test/parse-kernel-cmdline.pl | 2 +- > 29 files changed, 1374 insertions(+), 248 deletions(-) > create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/network_interface_pinning.json > create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/network_interface_pinning.toml > create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/network_interface_pinning_overlong_interface_name.json > create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/network_interface_pinning_overlong_interface_name.toml > create mode 100644 proxmox-tui-installer/src/views/network.rs _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel