From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4271C1FF165 for ; Thu, 6 Nov 2025 18:13:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A4481E684; Thu, 6 Nov 2025 18:14:13 +0100 (CET) Mime-Version: 1.0 Date: Thu, 06 Nov 2025 18:13:39 +0100 Message-Id: From: "Daniel Kral" To: "Proxmox VE development discussion" X-Mailer: aerc 0.21.0-10-gf12c391cb5b4 References: <20251031122834.62482-1-f.ebner@proxmox.com> In-Reply-To: <20251031122834.62482-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762449200413 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH-SERIES qemu-server/manager 0/7] VM CPU flags: introduce vendor-agnostic 'nested-virt' CPU flag X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Oct 31, 2025 at 1:27 PM CET, Fiona Ebner wrote: > The flag will automatically resolve to the flag required for the > current CPU on the host. The 'nested-virt' flag takes precendence over > the CPU-specific flag for nesting which might already be present with > custom CPU models. In that case, a warning is printed. > > Moves the cpu flag descriptions to qemu-server and introduces an API > endpoint for querying. Could later be extended with further > information, for example, which flags are actually supported on the > current host (some are specific to vendor or CPU). > > Dependency and build-dependency bump pve-manger -> qemu-server needed! Works great for what I have tested on an Intel CPU: - setting both `-nested-virt` and `+nested-virt` results in: CPU flag 'nested-virt' resolved to 'vmx' but only the latter will make `lscpu | grep vmx` true. I think it's valueable to also show it in the former case `-nested-virt`. - setting e.g. `-vmx` in a custom model and `+nested-virt` in the VM's cpu flags will result in: CPU flag 'nested-virt' resolved to 'vmx' warning: CPU flag/setting '+vmx' (manually set for VM) overwrites '-vmx' (set by custom CPU model) - but setting `-vmx` in the custom model and `-nested-virt` in the VM's cpu flags will result in only: CPU flag 'nested-virt' resolved to 'vmx' The same happens vice versa with `+vmx` in the custom model and `{+,-}nested-virt` in the VM's cpu flags. >From what I can figure this should also work with live migration, because resolve_cpu_flags will be called at vm_start, right? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel