From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B3C941FF165 for ; Thu, 6 Nov 2025 14:52:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 42F8017C55; Thu, 6 Nov 2025 14:52:58 +0100 (CET) Mime-Version: 1.0 Date: Thu, 06 Nov 2025 14:52:24 +0100 Message-Id: From: "Daniel Kral" To: "Proxmox VE development discussion" X-Mailer: aerc 0.21.0-10-gf12c391cb5b4 References: <20251020141335.124077-1-f.ebner@proxmox.com> <20251020141335.124077-7-f.ebner@proxmox.com> In-Reply-To: <20251020141335.124077-7-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762437125747 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v2 06/16] qmp client: better abstract peer in preparation for qemu-storage-daemon X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon Oct 20, 2025 at 4:12 PM CEST, Fiona Ebner wrote: > In preparation to add 'qsd' as a peer type for qemu-storage-daemon. > > There already are two different peer types, namely 'qga' for the QEMU > guest agent and 'qmp' for the QEMU instance itself. > > Future QMP peers (like the qemu-storage-daemon) are likely to use a > QMP monitor with capability negotiation like QEMU itself, so the > special handling done for the guest agent stays limited to the 'qga' > peer type. > > Replace the association with a VM ID and allow specifying an arbitrary > ID. > > Precise two error messages that used a hard-coded 'qmp' by specifing > the actual QMP peer type instead. The $peer structure also has a name > that is used for error messages to avoid hard-coding 'VM' there. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * Improve commit message. > * Further abstract QMP peer in QMP client/monitor modules: > Replace 'vmid' by 'id' and allow specifying a peer name for error > messages. This is preparation for use cases of the storage daemon > where there might not be a single associated guest. For example, > restoring from a backup provider via exports of a storage daemon, > and a second storage daemon for the TPM of the VM itself. Nice handling for the peer name! Reviewed-by: Daniel Kral _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel