From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 6C97D1FF165
	for <inbox@lore.proxmox.com>; Thu,  6 Nov 2025 10:12:57 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id BC51F10EDF;
	Thu,  6 Nov 2025 10:13:36 +0100 (CET)
Mime-Version: 1.0
Date: Thu, 06 Nov 2025 10:13:33 +0100
Message-Id: <DE1HW8VOWPIF.1OUKLHOODC1CH@proxmox.com>
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
 "Nicolas Frey" <n.frey@proxmox.com>
X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty
References: <20251106085423.99138-1-n.frey@proxmox.com>
In-Reply-To: <20251106085423.99138-1-n.frey@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1762420394958
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.028 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option
 to Arch property
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Thu Nov 6, 2025 at 9:54 AM CET, Nicolas Frey wrote:
> The `all` architecture is defined for e.g. all proxmox perl packages,
> so add it to the enum.
>
> This would lead to an error in the update view in PDM:
> [...] failed to parse api response: unknown variant `all` [...]
>
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>  PVE/API2/APT.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
> index 1ccbaf97..395ce070 100644
> --- a/PVE/API2/APT.pm
> +++ b/PVE/API2/APT.pm
> @@ -204,7 +204,7 @@ my $apt_package_return_props = {
>      Arch => {
>          type => 'string',
>          description => 'Package Architecture.',
> -        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x)],
> +        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x all)],
>      },
>      Description => {
>          type => 'string',

Looks good to me, thanks for the fix!

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel