From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C72161FF165 for ; Thu, 23 Oct 2025 13:20:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48D587EC4; Thu, 23 Oct 2025 13:20:47 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 23 Oct 2025 13:20:10 +0200 Message-Id: To: "Dominik Csapak" X-Mailer: aerc 0.20.0 References: <20251023083253.1038119-1-d.csapak@proxmox.com> In-Reply-To: <20251023083253.1038119-1-d.csapak@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761218402792 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager v2 00/16] prepare ui for customizable views X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Thu Oct 23, 2025 at 10:28 AM CEST, Dominik Csapak wrote: > This is the first step to have customizable views in the PDM ui. > > Patches 1-12 are refactors mostly and should not change behavior. > > Patch 13 is an improvement I noticed while doing this series, I can > send it upfront if wanted. > > Patches 14-16 are RFCs because: > * The `LoadResult` struct should probably live in either pwt or > yew-comp, I think Dietmar has already something local so I did not > want to interfere there. (We can switch to the one there if it's > committed and bumped) > > * Not super sure if this kind of structure is the one we desire. > The View is (for now) only a single layout (Row) that provides > the same behavior as the current layout. The whole logic is in the > View and every bit we want to add has to be handled there. > > Note that we'll have to move the types for the View/ViewLayout/etc. to > the pdm-api-types probably, since we'll also want to use them on the > backend. > > changes from v1: > * rebased on master > * added new patch to fix dashboard layout after change to views (patch 7) > > Dominik Csapak (16): > ui: dashboard: refactor guest panel creation to its own module > ui: dashboard: refactor creating the node panel into its own module > ui: dashboard: refactor remote panel creation into its own module > ui: dashboard: remote panel: make wizard menu optional > ui: dashboard: refactor sdn panel creation into its own module > ui: dashboard: refactor task summary panel creation to its own module > ui: dashboard: task summary: disable virtual scrolling > ui: dashboard: refactor subscription panel creation to its own module > ui: dashboard: refactor top entities panel creation to its own module > ui: dashboard: refactor DashboardConfig editing/constants to their > module > ui: dashboard: factor out task parameter calculation > ui: dashboard: remove unused remote list > ui: dashboard: status row: make loading less jarring > ui: introduce `LoadResult` helper type > ui: dashboard: implement 'View' > ui: dashboard: use 'View' instead of the Dashboard > > ui/src/dashboard/guest_panel.rs | 75 ++- > ui/src/dashboard/mod.rs | 784 +----------------------- > ui/src/dashboard/node_panel.rs | 150 +++++ > ui/src/dashboard/refresh_config_edit.rs | 107 ++++ > ui/src/dashboard/remote_panel.rs | 51 +- > ui/src/dashboard/sdn_zone_panel.rs | 15 +- > ui/src/dashboard/status_row.rs | 11 +- > ui/src/dashboard/subscription_info.rs | 54 +- > ui/src/dashboard/tasks.rs | 41 ++ > ui/src/dashboard/top_entities.rs | 45 +- > ui/src/dashboard/types.rs | 78 +++ > ui/src/dashboard/view.rs | 515 ++++++++++++++++ > ui/src/lib.rs | 5 +- > ui/src/load_result.rs | 42 ++ > ui/src/main_menu.rs | 5 +- > ui/src/pbs/remote.rs | 30 +- > ui/src/pve/lxc/overview.rs | 28 +- > ui/src/pve/mod.rs | 4 +- > ui/src/pve/node/overview.rs | 29 +- > ui/src/pve/qemu/overview.rs | 28 +- > ui/src/pve/storage.rs | 29 +- > 21 files changed, 1202 insertions(+), 924 deletions(-) > create mode 100644 ui/src/dashboard/node_panel.rs > create mode 100644 ui/src/dashboard/refresh_config_edit.rs > create mode 100644 ui/src/dashboard/types.rs > create mode 100644 ui/src/dashboard/view.rs > create mode 100644 ui/src/load_result.rs Other than the notes i left, consider this: Reviewed-by: Shannon Sterz Tested-by: Shannon Sterz _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel