From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9A6361FF165 for ; Thu, 23 Oct 2025 10:20:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0DCF930CB; Thu, 23 Oct 2025 10:21:20 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 23 Oct 2025 10:20:46 +0200 Message-Id: From: "Daniel Kral" To: "Fiona Ebner" , "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20251020164540.517231-1-d.kral@proxmox.com> <20251020164540.517231-9-d.kral@proxmox.com> <45195c25-ba32-452b-8501-3078987191fc@proxmox.com> In-Reply-To: <45195c25-ba32-452b-8501-3078987191fc@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761207638329 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH ha-manager v2 4/8] rules: resource affinity: decouple get_resource_affinity helper from Usage class X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue Oct 21, 2025 at 3:02 PM CEST, Fiona Ebner wrote: > Am 20.10.25 um 6:46 PM schrieb Daniel Kral: >> The resource affinity rules need information about the other HA >> resource's used nodes to be enacted correctly, which has been proxied >> through $online_node_usage before. >> >> The get_used_service_nodes(...) helper reflects the same logic to >> retrieve the nodes, where a HA resource $sid currently puts load on, as >> in recompute_online_node_usage(...). >> >> Signed-off-by: Daniel Kral >> Reviewed-by: Fiona Ebner >> --- >> changes since v1: >> - move get_used_service_nodes(...) helper to PVE::HA::Usage class >> - change get_used_service_nodes(...) signature from >> ($sd, $online_nodes) >> to >> ($online_nodes, $state, $node, $target) >> - change return value of get_used_service_nodes(...) from hash ref to >> two-element array >> - added R-b > > If there's this much change, I would prefer the R-b not to be added. The > v2 is a quite different patch from what I saw when giving the R-b. I did > review the v2 now, so you can keep the tag :) Right, I had the gut feeling that it this should get another look with the amount of changes, I'll keep that in mind the next time, thanks for the reminder :) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel