From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9E33D1FF16F for ; Tue, 14 Oct 2025 11:16:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9122B2487D; Tue, 14 Oct 2025 11:16:25 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 14 Oct 2025 11:15:52 +0200 Message-Id: To: "Shan Shaji" X-Mailer: aerc 0.20.0 References: <20251014085651.73407-1-s.shaji@proxmox.com> In-Reply-To: <20251014085651.73407-1-s.shaji@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760433316091 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, proxmox.com] Subject: Re: [pdm-devel] [PATCH datacenter-manager v2 0/2] fix #6901: add explicit permissions for PBS status and RRD endpoints X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Tue Oct 14, 2025 at 10:56 AM CEST, Shan Shaji wrote: > If a non-root user tried to view the overview of a PBS, a > "403: permission check failed" error was shown. Additionally, > the RRD data for the node and datastores were not visible. > > To fix the issue, explicit permission checks were added for > the PBS RRD endpoints and the PBS status endpoint. > > Ticket #6901 also reports a similar issue in the EVPN panel, > which will be addressed in a separate patch. > > Changelog > ========= > > since v1: Thanks @Shannon Sterz > patch: https://lore.proxmox.com/pdm-devel/20251010151803.257519-1-s.shaji@proxmox.com/T/#t > > - Updated description for both status and RRD endpoints. > - Updated commit message. > > Shan Shaji (2): > fix #6901: api: add permission checks for PBS rrd endpoints > fix #6901: api: remove `node` reference from templated privilege path > > server/src/api/pbs/mod.rs | 3 ++- > server/src/api/pbs/rrddata.rs | 11 ++++++++++- > 2 files changed, 12 insertions(+), 2 deletions(-) looks good to me, consider this: Reviewed-by: Shannon Sterz _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel