From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F23B71FF15E for ; Mon, 13 Oct 2025 10:41:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 81140E264; Mon, 13 Oct 2025 10:42:12 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 13 Oct 2025 10:41:39 +0200 Message-Id: To: "Shan Shaji" X-Mailer: aerc 0.20.0 References: <20251010151803.257519-1-s.shaji@proxmox.com> <20251010151803.257519-3-s.shaji@proxmox.com> In-Reply-To: <20251010151803.257519-3-s.shaji@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760344863794 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 2/2] fix #6901: api: remove `node` reference from templated privilege path X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Fri Oct 10, 2025 at 5:18 PM CEST, Shan Shaji wrote: > If a non root user tried to view the overview of a PBS, it was > showing "403: permission check failed" error. This occured because the > privilege path included the "node" object which is neither accepted > as a parameter in the endpoint nor passed from the UI. > > To fix the issue removed the "node" reference. Now if the user has > atleast the `Resource.Audit` permission, they can view PBS status under > the overview panel. > > Signed-off-by: Shan Shaji > --- > server/src/api/pbs/mod.rs | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/server/src/api/pbs/mod.rs b/server/src/api/pbs/mod.rs > index dc31f62..65a2e43 100644 > --- a/server/src/api/pbs/mod.rs > +++ b/server/src/api/pbs/mod.rs > @@ -272,7 +272,8 @@ pub async fn scan_remote_pbs( > }, > }, > access: { > - permission: &Permission::Privilege(&["resource", "{remote}", "node", "{node}"], PRIV_RESOURCE_AUDIT, false), > + permission: &Permission::Privilege(&["resource", "{remote}"], PRIV_RESOURCE_AUDIT, false), > + description: "The user needs to have atleast `Resource.Audit` privilege under `/resource`." nit: same as previous patch, should be: The user needs to have at least the `Resource.Audit` privilege on `/resource/{remote}/node/{node}`. > }, > )] > /// Get status for the PBS remote other than this and the comments on the previous patch Reviewed-by: Shannon Sterz _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel