From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B3C711FF165 for ; Thu, 9 Oct 2025 11:57:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3FE2F1B31B; Thu, 9 Oct 2025 11:57:16 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 09 Oct 2025 11:56:42 +0200 Message-Id: To: "Shannon Sterz" , X-Mailer: aerc 0.20.0 References: <20251008151936.386950-1-s.sterz@proxmox.com> In-Reply-To: <20251008151936.386950-1-s.sterz@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760003771006 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [yew-devel] [PATCH yew-comp 0/2] openid and default realm support in login panel X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" On Wed Oct 8, 2025 at 5:19 PM CEST, Shannon Sterz wrote: > these patches add support for handling the default realm and openid > login flow for the login panel. > > note that we already shipped the pve-yew-mobile-gui without support for > openid login flows. so bumping that with this applied would be helpful > for users that want to use the new mobile gui with an openid realm. > one small note about this: this patch series does not play as nicely with the consent text implemented in the mobile gui as the desktop ui does with its implementation. users would have to click the "OK" button twice. once before starting the openid flow and a second time after being redirected. we could expose the helper that parses the search parameters in `utils.rs`. then yew-mobile-gui could query the search parameters, if they are there render the LoginPanel instead of showing the consent text again. so more or less the same approach to the one we use in our javascript front-ends. this would safe users from having to submit the consent text twice. also small note on that helper: while i could have used the url crate [1] to parse the search parameters there, i already had the manual approach outlined there implemented. since it saved me the hassle of dealing with an extra `Result` i stuck to it. i can adapt this in a v2 if desired, though. would still appreciate some feedback on the general approach used here. thanks! [1]: https://docs.rs/url/latest/url/struct.Url.html#method.query_pairs > Shannon Sterz (2): > login_panel/realm_selector: use default realm provided by api > login_panel/realm_selector: add support for openid realm logins > > src/login_panel.rs | 327 +++++++++++++++++++++++++++++++++--------- > src/realm_selector.rs | 85 ++++++++++- > 2 files changed, 340 insertions(+), 72 deletions(-) > > -- > 2.47.3 _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel