From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7B6A81FF17E for ; Thu, 2 Oct 2025 12:21:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2037FC60D; Thu, 2 Oct 2025 12:21:25 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 02 Oct 2025 12:21:21 +0200 Message-Id: Cc: "yew-devel" To: "Yew framework devel list at Proxmox" X-Mailer: aerc 0.20.0 References: <20250923125053.2944385-1-d.csapak@proxmox.com> In-Reply-To: <20250923125053.2944385-1-d.csapak@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759400458767 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [yew-devel] [PATCH yew-widget-toolkit] widget: catalog loader: set text direction after load X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" one small nit in-line On Tue Sep 23, 2025 at 2:50 PM CEST, Dominik Csapak wrote: > The text direction is already set when the language changes via the > LanguageSelector, but on page load this can only be done by the catalog > loader, so do it there too, otherwise the text direction is not set > after a reload of the page, even if the language itself is correct. > > Signed-off-by: Dominik Csapak > --- > src/widget/catalog_loader.rs | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/widget/catalog_loader.rs b/src/widget/catalog_loader.rs > index a8a14f5..6517302 100644 > --- a/src/widget/catalog_loader.rs > +++ b/src/widget/catalog_loader.rs > @@ -5,7 +5,8 @@ use yew::html::IntoPropValue; > use yew::virtual_dom::{VComp, VNode}; > > use crate::props::{IntoOptionalTextRenderFn, TextRenderFn}; > -use crate::state::{Language, LanguageObserver}; > +use crate::state::{get_language_info, Language, LanguageObserver}; > +use crate::widget::rtl_switcher::set_text_direction; > use crate::{impl_to_html, prelude::*}; > > use pwt_macros::builder; > @@ -107,6 +108,11 @@ impl Component for PwtCatalogLoader { > let props = ctx.props(); > match msg { > Msg::LoadDone => { > + if let Some(info) = get_language_info(&self.lang) { > + if let Err(err) = set_text_direction(info.direction) { > + log::error!("could not set text direction: {err}"); > + } > + } do we want to log something if `get_language_info` returns None? if i'm not missing this happens when `self.lang` is set to something that isn't part of AVAILABLE_LANGUAGES. which is unlikely to happen unless someone messes with the local storage here manually i suppose. still, might be nice to have. > self.state = LoadState::Idle; > true > } _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel