From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BEABC1FF16B for ; Fri, 26 Sep 2025 14:07:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A0C7ED9D; Fri, 26 Sep 2025 14:08:20 +0200 (CEST) Mime-Version: 1.0 Date: Fri, 26 Sep 2025 14:07:45 +0200 Message-Id: To: "Stoiko Ivanov" , From: "Max R. Carrara" X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20250924180538.9281-1-s.ivanov@proxmox.com> <20250924180538.9281-3-s.ivanov@proxmox.com> In-Reply-To: <20250924180538.9281-3-s.ivanov@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758888450315 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.086 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api v2 2/2] templates: fetchmail: add comment where users can add manual accounts X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" On Wed Sep 24, 2025 at 8:05 PM CEST, Stoiko Ivanov wrote: > our fetchmail module uses /etc/fetchmailrc (symlinked to > /etc/pmg/fetchmailrc) as authoritative source for fetchmail accounts. > > This means that if users need to make adaptations to fetchmail options > it breaks the handling of fetchmail in the API and GUI. > > based on feedback from #6798 I think providing a hint where users > can add accounts with manual overrides, while keeping the API/GUI > working for all other accounts should help. > > Signed-off-by: Stoiko Ivanov > --- > src/templates/fetchmailrc.tt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/templates/fetchmailrc.tt b/src/templates/fetchmailrc.tt > index 76e591ca..f7f341de 100644 > --- a/src/templates/fetchmailrc.tt > +++ b/src/templates/fetchmailrc.tt > @@ -9,6 +9,9 @@ defaults: > > smtphost [% ipconfig.int_ip %]/[% pmg.mail.ext_port %] > > +# add manually configured accounts below and before 'proxmox settings'(to keep the UI working) Small nit: would add a space after 'proxmox settings' above, so the parenthesis isn't glued to it: add manually configured accounts below and before 'proxmox settings' (to keep the UI working) Alternatively, the text in parentheses can also go to be fair; users don't necessarily need to know up front that the UI will break if they edit the wrong parts of the file, IMO. > + > + > # proxmox settings (Do not delete this marker!!) > [% FOREACH item IN fetchmail_users.list('values') %] > [% IF item.enable %]poll[% ELSE %]skip[% END -%] _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel