From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B12E31FF191 for ; Tue, 23 Sep 2025 16:57:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1DF7711F01; Tue, 23 Sep 2025 16:58:19 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 23 Sep 2025 16:58:15 +0200 Message-Id: Cc: "yew-devel" To: "Yew framework devel list at Proxmox" X-Mailer: aerc 0.20.0 References: <20250923131429.3082622-1-d.csapak@proxmox.com> In-Reply-To: <20250923131429.3082622-1-d.csapak@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758639483003 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [yew-devel] [RFC PATCH yew-widget-toolkit-assets] flip font-awesome icons for rtl text direction X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" On Tue Sep 23, 2025 at 3:11 PM CEST, Dominik Csapak wrote: > when using a language that sets the text direction to RTL, font-awesome > icons that have left or right in the name are pointing in the wrong > direction, so flip them. > > This happens for example in menus, back button of the material app, > list tiles where icons like 'chevron-right' are used, etc. > > Signed-off-by: Dominik Csapak > --- > sending as rfc because i'm not sure this is the right approach. > > alternatively we could create our own classes for every font-awesome > class that ends with -left/-right and call them -start/-end and > have only them flip in a rtl setting > > Advantage would be that users could still use the 'left' and 'right' > variants if they need/want them. i think i'd be in favor of this. there are already some approaches like that out there [1]. it's clearer and sometime we may want an arrow to always point left (or right) as pointed out by dietmar. [1]: https://github.com/fisharebest/font-awesome-rtl/blob/master/font-awesome-rtl.css > scss/_miscellaneous.scss | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/scss/_miscellaneous.scss b/scss/_miscellaneous.scss > index c0dfafe..05dfd61 100644 > --- a/scss/_miscellaneous.scss > +++ b/scss/_miscellaneous.scss > @@ -156,3 +156,11 @@ a:focus-within, a:hover { > .pwt-pointer { > cursor: pointer; > } > + > +/* rtl inversions of icons */ > +.fa[class*="-left"], > +.fa[class*="-right"] { > + &:dir(rtl) { > + transform: scaleX(-1); > + } > +} _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel