From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EA9D31FF187 for ; Mon, 22 Sep 2025 15:57:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6EDBE1DA0C; Mon, 22 Sep 2025 15:58:11 +0200 (CEST) Date: Mon, 22 Sep 2025 15:58:08 +0200 To: Mime-Version: 1.0 Message-Id: X-Mailer: aerc 0.20.0 References: <20250916144827.551806-1-s.sterz@proxmox.com> In-Reply-To: From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758549476691 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp 00/11] Add LDAP and AD realm support to Proxmox Datacenter Manager X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" one more thing: On Fri Sep 19, 2025 at 1:11 PM CEST, Shannon Sterz wrote: > On Fri Sep 19, 2025 at 12:02 PM CEST, Christoph Heiss wrote: -->8 snip 8<-- >> - PVE/PBS have the ability to also sync the `comment` field from some >> attribute (e.g. `sync-attributes comment=userPrincipal`), for PDM >> this currently is not allowed by the schema. But this can be part of a >> future improvement IMO. > > will take a look at this as well, must have missed that as it wasn't > exposed in the ui. did that now, but this is not actually something pbs supports. looking at the sync logic [1] comments are only preserved, not synced from the realm. the SyncAttributes schema also does not have a `Comment` variant [2]. so i think for now getting the existing logic into a common crate takes precedence over implementing feature parity with pve imo. meaning, i'll leave this as a follow up. [1]: https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=src/server/realm_sync_job.rs;h=8768a0d80fcfda10dc7e1549592556b1ccc6f347;hb=HEAD#l295 [2]: https://git.proxmox.com/?p=proxmox.git;a=blob;f=pbs-api-types/src/ldap.rs;h=5114616055bca1e032c4222cff8b0047ca6bb514;hb=HEAD#l180 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel