From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CB9861FF186 for ; Thu, 18 Sep 2025 10:44:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6FADA1511B; Thu, 18 Sep 2025 10:44:33 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 18 Sep 2025 10:44:30 +0200 Message-Id: From: "Shan Shaji" To: "Thomas Lamprecht" , "Dominik Csapak" , "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20250904092548.59064-1-s.shaji@proxmox.com> <14c1d1f4-33eb-4d83-a26d-5d5396af5508@proxmox.com> <9c6bdbb6-b99b-47c7-97d0-38e4931838b6@proxmox.com> In-Reply-To: <9c6bdbb6-b99b-47c7-97d0-38e4931838b6@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758185061361 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.143 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v3] feat: ui: add lock/unlock button in guests options page X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thanks @Thomas and @Dominik for the review, I will create another patch that will align with the mobile web UI which will be a bottom sheet with the explicit update or reset button. Also, the changes will only reflect on the existing editable options. On Wed Sep 17, 2025 at 10:41 AM CEST, Thomas Lamprecht wrote: > Am 17.09.25 um 10:06 schrieb Dominik Csapak: >> >> >> On 9/4/25 11:25 AM, Shan Shaji wrote: >>> On the options page for VMs and CTs it was easy to change the >>> configs by mistake. To avoid that, added a lock/unlock button >>> on top of the screen. The toggle buttons will only be enabled >>> if the button is clicked. >>> >>> Suggested-by: Thomas Lamprecht >>> Signed-off-by: Shan Shaji >> I did not apply this, as we're currently evaluating a different approach >> for the yew mobile ui. If that works out, i'd prefer to have both uis >> the same (or at least similar) approaches here > > For the record: the idea is just using bottom sheets with an explicit > "update" save button for each property, i.e. both, single value ones > and more complex property strings. > > As we do not plan to very actively extend the Apps capabilities to cover > the full option range for VMs/CTs that PVE allows and just keep the > simple options we got now I'm not really sure if syncing app and mobile > web is really something we have to do. That said, I have nothing against > using a bottom sheet there too, it's a common approach and works well > for most things, but I'm also fine with going a different route, > especially if we do not expand the availability of options and HW to > configure soon(ish) here anyway, we can still change this later should > that happen. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel