From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 490B71FF17C for ; Wed, 3 Sep 2025 12:16:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1430D891E; Wed, 3 Sep 2025 12:17:04 +0200 (CEST) Date: Wed, 03 Sep 2025 12:16:30 +0200 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Proxmox VE development discussion" Cc: "pve-devel" Mime-Version: 1.0 X-Mailer: aerc 0.20.1 References: <20250902101713.82292-1-s.shaji@proxmox.com> <20250902101713.82292-3-s.shaji@proxmox.com> In-Reply-To: <20250902101713.82292-3-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756894575117 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pub.dev] Subject: Re: [pve-devel] [PATCH proxmox_dart_api_client 1/2] fix: android: use `crone_http` package to honor user custom certificates X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue Sep 2, 2025 at 12:17 PM CEST, Shan Shaji wrote: > In android when a user installs a custom certificate the app was not > honoring the installed certificate and was still throwing > `HandShakeException`. > > To fix the issue, used the `crone_http` [0] package which will honor the nit: s/crone_http/cronet_http Also: if I understand correctly based on quick search, the regular dart:io HttpClient simply doesn't honor user-installed certificates at all and there's no way to change that at the moment [0]? So adding this dependency is necessary because it's one of the few ways (or maybe the only way at the moment) to allow using user-installed certificates, right? Just asking because I think it's always good to have some rationale for additional dependencies. Might make sense to add this to the commit message as well, I think. [0] https://github.com/dart-lang/sdk/issues/50435 > user installed certificates. Used the standalone embedded library [1] of > cronet inorder to avoid the dependency on Google Play Services. > > [0] - https://pub.dev/packages/cronet_http > [1] - https://pub.dev/packages/cronet_http#use-embedded-cronet > > Signed-off-by: Shan Shaji _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel