From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E084C1FF17C for ; Wed, 3 Sep 2025 11:48:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CA2B82FE31; Wed, 3 Sep 2025 11:48:40 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 03 Sep 2025 11:48:07 +0200 Message-Id: From: "Lukas Wagner" To: "Stefan Hanreich" , "Proxmox Datacenter Manager development discussion" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250902151427.425017-1-l.wagner@proxmox.com> <20250902151427.425017-10-l.wagner@proxmox.com> <8b20cc07-8c04-47e6-bc95-3547a40e07a7@proxmox.com> In-Reply-To: <8b20cc07-8c04-47e6-bc95-3547a40e07a7@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756892872220 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager 3/4] ui: pve: move node overview to a new overview tab X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Wed Sep 3, 2025 at 11:10 AM CEST, Stefan Hanreich wrote: > one small nit inline (pre-existing) I noticed while looking over the changes > >> +impl yew::Component for NodeOverviewPanelComp { >> + type Message = Msg; >> + type Properties = NodeOverviewPanel; >> + >> + fn create(ctx: &yew::Context) -> Self { >> + ctx.link().send_message(Msg::ReloadRrd); >> + ctx.link().send_message(Msg::ReloadStatus); >> + Self { >> + time_data: Rc::new(Vec::new()),> + cpu_data: Rc::new(Series::new("", Vec::new())), >> + load_data: Rc::new(Series::new("", Vec::new())), >> + mem_data: Rc::new(Series::new("", Vec::new())), >> + mem_total_data: Rc::new(Series::new("", Vec::new())), > > pre-existing but this could profit from a Default implementation > Mhhm, does that make sense though? Default::default is off course public, and it does not really make much sense to offer a second way to instantiate the component that is not `create`... but maybe I'm missing something here. >> + rrd_time_frame: RRDTimeframe::load(), >> + status: None, >> + last_error: None, >> + last_status_error: None, >> + async_pool: AsyncPool::new(), >> + _timeout: None, >> + _status_timeout: None, >> + } >> + } >> + _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel