From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5ED4E1FF16F for ; Tue, 2 Sep 2025 16:47:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E8A3E17895; Tue, 2 Sep 2025 16:47:29 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 02 Sep 2025 16:47:26 +0200 Message-Id: From: "Daniel Kral" To: "Proxmox VE development discussion" Cc: "pve-devel" X-Mailer: aerc 0.20.0 References: <20250902124524.368080-1-m.sandoval@proxmox.com> <20250902124524.368080-7-m.sandoval@proxmox.com> In-Reply-To: <20250902124524.368080-7-m.sandoval@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756824432887 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v2 6/6] deprecate freeze-fs-on-backup qga setting X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue Sep 2, 2025 at 2:45 PM CEST, Maximiliano Sandoval wrote: > Signed-off-by: Maximiliano Sandoval > --- > src/PVE/QemuServer.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm > index cdd44eb0..b8416b4c 100644 > --- a/src/PVE/QemuServer.pm > +++ b/src/PVE/QemuServer.pm > @@ -161,8 +161,10 @@ my $agent_fmt = { > optional => 1, > default => 0, > }, > + # TODO Remove in Proxmox VE 10 > 'freeze-fs-on-backup' => { > - description => "Freeze/thaw guest filesystems on backup for consistency.", > + description => "Freeze/thaw guest filesystems on backup for consistency.\n\n" > + . "Deprecated: Use 'guest-fsfreeze' instead", nit: end the deprecation notice with a full-stop also seems like we put the deprecation notice at the start instead of the end, at least what I found with a quick grep over all PVE repos (exception: qm's bootdisk): Deprecated: Use 'guest-fsfreeze' instead. Freeze/thaw guest filesystems on backup for consistency. > type => 'boolean', > optional => 1, > default => 1, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel