From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B36FF1FF16F for ; Tue, 2 Sep 2025 16:43:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7984A176A1; Tue, 2 Sep 2025 16:43:22 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 02 Sep 2025 16:43:19 +0200 Message-Id: Cc: "pve-devel" From: "Daniel Kral" To: "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20250902124524.368080-1-m.sandoval@proxmox.com> <20250902124524.368080-2-m.sandoval@proxmox.com> In-Reply-To: <20250902124524.368080-2-m.sandoval@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756824185403 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: Re: [pve-devel] [PATCH qemu-server v2 1/6] add a guest-fsfreeze qga setting X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue Sep 2, 2025 at 2:45 PM CEST, Maximiliano Sandoval wrote: > Adds a new setting that controls whether guest-fsfreeze-{freeze,thaw} > commands should be issued. The previous setting was only taken into > account for backups. > > In this commit we only use this setting for backups. The following two > commits will ensure the setting is used on replications, snapshots and > clones. > > Signed-off-by: Maximiliano Sandoval > --- > src/PVE/QemuServer.pm | 11 +++++++++++ > src/PVE/VZDump/QemuServer.pm | 6 +++++- > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm > index f263fedb..cdd44eb0 100644 > --- a/src/PVE/QemuServer.pm > +++ b/src/PVE/QemuServer.pm > @@ -167,6 +167,17 @@ my $agent_fmt = { > optional => 1, > default => 1, > }, > + 'guest-fsfreeze' => { > + description => > + "Whether to issue the guest-fsfreeze-freeze and guest-fsfreeze-thaw QEMU guest agent commands.\n\n" > + . "Backups in snapshot mode, clones, snapshots without RAM, and replications normally issue a " > + . "fsfreeze-fsfreeze-freeze and a respective thaw command when the QEMU Guest agent option is " > + . "enabled on the guest's configuration and the agent is running inside of the guest.\n\n" > + . "Takes preference over 'freeze-fs-on-backup' when set.", 'Takes preference over' should be 'Takes precedence over'. nit: But I think it'd be easier for users to understand something like When this property/option is set, it will override the setting of 'freeze-fs-on-backup'. > + type => 'boolean', > + optional => 1, > + default => 1, > + }, > type => { > description => "Select the agent type", > type => 'string', > diff --git a/src/PVE/VZDump/QemuServer.pm b/src/PVE/VZDump/QemuServer.pm > index 5b94c369..2879639a 100644 > --- a/src/PVE/VZDump/QemuServer.pm > +++ b/src/PVE/VZDump/QemuServer.pm > @@ -1096,7 +1096,11 @@ sub qga_fs_freeze { > return; > } > > - my $freeze = PVE::QemuServer::get_qga_key($self->{vmlist}->{$vmid}, 'freeze-fs-on-backup') // 1; > + my $freze_fs_on_backup = s/freze/freeze/ > + PVE::QemuServer::get_qga_key($self->{vmlist}->{$vmid}, 'freeze-fs-on-backup'); > + my $guest_fsfreeze = PVE::QemuServer::get_qga_key($self->{vmlist}->{$vmid}, 'guest-fsfreeze'); > + > + my $freeze = $guest_fsfreeze // $freze_fs_on_backup // 1; could also just be my $freeze = PVE::QemuServer::get_qga_key($self->{vmlist}->{$vmid}, 'guest-fsfreeze'); $freeze //= PVE::QemuServer::get_qga_key($self->{vmlist}->{$vmid}, 'freeze-fs-on-backup'); $freeze //= 1; or something like that to not have unnecessary temporary variables. > if (!$freeze) { > $self->loginfo("skipping guest-agent 'fs-freeze', disabled in VM options"); > return; _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel