From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 367DC1FF16F for ; Tue, 2 Sep 2025 14:21:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5AAC2122E2; Tue, 2 Sep 2025 14:21:12 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 02 Sep 2025 14:21:08 +0200 Message-Id: Cc: "pve-devel" From: "Daniel Kral" To: "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20250902114852.229752-1-a.mohammed@proxmox.com> In-Reply-To: <20250902114852.229752-1-a.mohammed@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756815654624 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH] ha: Correct in-text references to Available HA Rule Types X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue Sep 2, 2025 at 1:48 PM CEST, abobakr mohammed wrote: > Corrected the descriptions of affinity rules in Table 2 (they were previously reversed). > Changed "seperate" to "negative". > > Signed-off-by: abobakr mohammed Thanks for spotting this and sending a patch! A few small points: The PATCH in the subject line should be "PATCH pve-docs" or just "PATCH docs", so everyone knows which repository it belongs to ;). You can do that by using git format-patch --subject-prefix="PATCH docs" -v2 ... when formatting the patch. We usually use only lowercase for the subject line too, but that's more nit-picking from my side. The commit message should be imperative (e.g. "Change X to Y" instead of "Changes/Changed X to Y") and the line length must not be longer than 72 characters. See [0] for more information. [0] https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages With those addressed, consider this as: Reviewed-by: Daniel Kral _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel