From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 154A71FF15E for ; Mon, 1 Sep 2025 15:24:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D7762F799; Mon, 1 Sep 2025 15:24:56 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 01 Sep 2025 15:24:22 +0200 Message-Id: Cc: "pve-devel" To: "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20250829094401.223667-1-m.sandoval@proxmox.com> In-Reply-To: <20250829094401.223667-1-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756733050576 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2 1/2] ui: set proxmoxRRDChart's unit at storage summary X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Aug 29, 2025 at 11:43 AM CEST, Maximiliano Sandoval wrote: > This change ensures that the storage unites are displayed consistently > between the graph and the usage label right above. > > When setting the unit to `bytes` the graph will now, for example, show > "130 GB" instead of "130 G", which matches the usage displayed above and > removes any ambiguity about whether "G" refers to GiB or GB. > > Signed-off-by: Maximiliano Sandoval > --- > > Differences from v1: > > - Use lowercase in commit name > - Add a second commit changing the renderer of the bytes_used > > > www/manager6/storage/Summary.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/www/manager6/storage/Summary.js b/www/manager6/storage/Summary.js > index 8809603b..b263cb87 100644 > --- a/www/manager6/storage/Summary.js > +++ b/www/manager6/storage/Summary.js > @@ -52,6 +52,7 @@ Ext.define('PVE.storage.Summary', { > fields: ['total', 'used'], > fieldTitles: ['Total Size', 'Used Size'], > store: rrdstore, > + unit: 'bytes', > }, > ], > listeners: { looks good to me, consider this: Tested-by: Shannon Sterz Reviewed-by: Shannon Sterz _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel