From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6A0AA1FF165 for ; Thu, 28 Aug 2025 15:26:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E96A510FC6; Thu, 28 Aug 2025 15:26:44 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 28 Aug 2025 15:26:41 +0200 Message-Id: From: "Daniel Kral" To: "Proxmox VE development discussion" Cc: "pve-devel" X-Mailer: aerc 0.20.0 References: <20250828124933.338289-1-m.sandoval@proxmox.com> In-Reply-To: <20250828124933.338289-1-m.sandoval@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756387594906 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] document hugepages option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu Aug 28, 2025 at 2:49 PM CEST, Maximiliano Sandoval wrote: > Given that there is no 0 enum, we remove the word "disabled" from the > docs. We also document that the unit is MiB. > > Signed-off-by: Maximiliano Sandoval > --- > src/PVE/QemuServer.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm > index f263fedb..9d2bba71 100644 > --- a/src/PVE/QemuServer.pm > +++ b/src/PVE/QemuServer.pm > @@ -442,7 +442,10 @@ EODESC > hugepages => { > optional => 1, > type => 'string', > - description => "Enable/disable hugepages memory.", > + description => > + "Enables hugepages memory.\n\nSets the size of hugepages in MiBs. If the value " > + . "is set to 'any' then 1 GiB hugepages will be used if possible, " > + . "otherwise the size will fall back to 2 MiB.", > enum => [qw(any 2 1024)], > }, > keephugepages => { As discussed off-list, it might be nice to have a 'off' option, as users might not come to the conclusion that hugepages can only be disabled by deleting the property from the config, but the change in description definitely clarifies what the values mean here, so LGTM. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel