From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BFEF81FF187 for ; Mon, 25 Aug 2025 10:43:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D2420C872; Mon, 25 Aug 2025 10:44:00 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 25 Aug 2025 10:43:57 +0200 Message-Id: From: "Lukas Wagner" To: "Dominik Csapak" , "Proxmox Datacenter Manager development discussion" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250821095319.134215-1-l.wagner@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756111433632 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.125 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager v6 00/23] metric collection improvements (concurrency, API, CLI) X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Fri Aug 22, 2025 at 1:51 PM CEST, Dominik Csapak wrote: > aside from the issue with the last 10 minute gap of data in the hourly > view, code LGTM and tested fine, did not notice anything else off > > Some patches (especially the last 3) could possibly be squashed in to > earlier patches (no biggie though) Will do, if I can do it without large conflicts while rebasing. > > Since this is a rather large series, I'd like to see a reviewed-by from > someone else before applying, since the reviewed-by from maximiliano > came in at v2 i think, and there were some noticeable changes since > then. > > With that said, consider this round > > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak [copied from your other reponse]: On Fri Aug 22, 2025 at 2:49 PM CEST, Dominik Csapak wrote: > ah one thing i forgot to mention: > > i'd probably favor doing it the way you described here: > > > > - Should `GET /remotes//metric-collection-rrddata` be > > just `rrddata`? > > not sure if we are going to add any other PDM-native per-remote > > metrics and whether we want to return that from the same API call > > as this... > > i think it's fine to mix it here Alright, I'll rename it to just `rrddata` then. > > also the /metric-collection/rrddata could be merged > with a (not yet implemented) rrddata endpoint in the /nodes/localhost path Will do! > > i guess we want to expose some pdm host rrddata sooner or later anyway > there we can include this too? [copied from your other response]: On Fri Aug 22, 2025 at 1:27 PM CEST, Dominik Csapak wrote: >> We also could trigger an out-of-schedule metric collection for a remote >> when the RRD graph calls the rrddata endpoint (the functions for >> triggering the collection of a single remote are already there, albeit >> non-blocking, so this would need some changes). Fetching the missing >> data for a single remote should be fast enough any way. The rrddata >> endpoint could have some timeout for waiting for the results of >> collecting that single remote; if that one is exceeded we don't wait >> until the collection results are done but simply return the existing >> data. >> > > The problem is actually just the 'hourly' graphs, since there the > interval is so small one noticed the 10 minutes quite often. > > All others (daily,monthly, etc.) don't exhibit the same problem > > so i'd say if we can fetch missing data on-the-fly in the api call > for hourly calls, it would be good enough Alright, will try to implement something akin to what I've described for v7. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel