From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7AA651FF170 for ; Thu, 21 Aug 2025 13:45:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F8811EB1E; Thu, 21 Aug 2025 13:45:49 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 21 Aug 2025 13:45:45 +0200 Message-Id: To: "Proxmox Datacenter Manager development discussion" , "Dominik Csapak" , "Thomas Lamprecht" From: "Lukas Wagner" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250821084229.1523597-1-d.csapak@proxmox.com> In-Reply-To: <20250821084229.1523597-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755776745091 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 00/23] ] improve remote wizard X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Thu Aug 21, 2025 at 10:39 AM CEST, Dominik Csapak wrote: > ## Fingerprint confirmation dialogs > > Not sure if we want to be able to let the user confirm the fingerprint > so easily. On one hand it's very convenient, but maybe leads to users > simply clicking yes without understanding what's happening. > > If it's deemed too dangerous, I'd rework the series without this. As said in v2, I think it's fine to have such a dialog, but I'd like to hear some other opinions before we apply this. @Thomas, do you have an opinion on this? > > # Future work > [snip] > ui/src/remotes/wizard_page_connect.rs | 314 +++++++++++++++++--------- > ui/src/remotes/wizard_page_info.rs | 121 +++++----- > ui/src/remotes/wizard_page_nodes.rs | 239 +++++++++++++++++++- > ui/src/remotes/wizard_page_summary.rs | 5 +- > ui/src/widget/mod.rs | 3 + > ui/src/widget/pve_realm_selector.rs | 123 ++++++++++ > 15 files changed, 872 insertions(+), 203 deletions(-) > create mode 100644 ui/src/widget/pve_realm_selector.rs Gave this one another go. Code looks good to me, only two minor complaints about outdated doc comments and one question about the permissions for the tls-probe endpoint (see individual patches). Consider this: Reviewed-by: Lukas Wagner Also tested this again, found two small issues: - Seems like the realm selector is still not disabled when "Use existing token" is selected - When you modify something in the "Endpoints" tab (e.g. the IP address for some endpoint), go back to "Settings" and then back to "Endpoints", the changes are lost - I guess in this case the info is fetched again from the API and the changes overwritten. These could also be fixed in a follow-up, since these do not impeded the core functionality of the dialog, IMO. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel