From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7DA321FF16F for ; Tue, 19 Aug 2025 13:53:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F9E713443; Tue, 19 Aug 2025 13:55:05 +0200 (CEST) Date: Tue, 19 Aug 2025 13:55:02 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" , "Dominik Csapak" Mime-Version: 1.0 X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250516133611.3499075-1-d.csapak@proxmox.com> <20250516133611.3499075-6-d.csapak@proxmox.com> In-Reply-To: <20250516133611.3499075-6-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755604459815 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 05/21] pdm-client: add scan_remote and probe_tls methods X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Fri May 16, 2025 at 3:35 PM CEST, Dominik Csapak wrote: > so we can use that in the ui instead of making the api calls manually > via the path. > > Signed-off-by: Dominik Csapak > --- > lib/pdm-client/src/lib.rs | 45 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/lib/pdm-client/src/lib.rs b/lib/pdm-client/src/lib.rs > index 61a8ebd..d656ab1 100644 > --- a/lib/pdm-client/src/lib.rs > +++ b/lib/pdm-client/src/lib.rs > @@ -3,6 +3,7 @@ > use std::collections::HashMap; > use std::time::Duration; > > +use pdm_api_types::remotes::ScanResult; > use pdm_api_types::resource::{PveResource, RemoteResources, TopEntities}; > use pdm_api_types::rrddata::{ > LxcDataPoint, NodeDataPoint, PbsDatastoreDataPoint, PbsNodeDataPoint, QemuDataPoint, > @@ -865,6 +866,50 @@ impl PdmClient { > .build(); > Ok(self.0.get(&path).await?.expect_json()?.data) > } > + > + /// uses /pve/scan to probe the tls connection to the given host > + pub async fn pve_probe_tls( > + &self, > + hostname: &str, > + fingerprint: Option<&str>, > + ) -> Result { > + let mut params = json!({ > + "hostname": hostname, > + }); > + if let Some(fp) = fingerprint { > + params["fingerprint"] = fp.into(); > + } > + Ok(self > + .0 > + .post("/api2/extjs/pve/scan", ¶ms) > + .await? > + .expect_json()? > + .data) > + } > + > + /// Uses /pve/scan to scan the remote cluster for node/fingerprint information > + pub async fn pve_scan_remote( > + &self, > + hostname: &str, > + fingerprint: Option<&str>, > + authid: &str, > + token: &str, > + ) -> Result { > + let mut params = json!({ > + "hostname": hostname, > + "authid": authid, > + "token": token, > + }); > + if let Some(fp) = fingerprint { > + params["fingerprint"] = fp.into(); > + } > + Ok(self > + .0 > + .post("/api2/extjs/pve/scan", ¶ms) > + .await? > + .expect_json()? > + .data) > + } > } Yep, this also confirms my opinion that the /scan endpoint is a bit odd right now and should better be split up :) > > /// Builder for migration parameters. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel