From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 22EC51FF185 for ; Mon, 18 Aug 2025 12:03:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 73E92349D4; Mon, 18 Aug 2025 12:04:52 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 18 Aug 2025 12:04:18 +0200 Message-Id: From: "Shan Shaji" To: "Shan Shaji" , "Dominik Csapak" , "Proxmox VE development discussion" X-Mailer: aerc 0.14.0 References: <20250814093219.75803-1-s.shaji@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755511419445 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.185 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v4] ui: enable noVNC console on iOS X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Superseded by v5: https://lore.proxmox.com/pve-devel/20250818100134.30550-1-s.shaji@proxmox.com/T/#t On Thu Aug 14, 2025 at 2:26 PM CEST, Shan Shaji wrote: > > hi, > > > > thanks for sending the patch again without dart format changes (mostly, > > see my comment on the last hunk) > > > > while the changes themselves look ok to me, i would have liked it more > > for the different changes to be different patches > > > > e.g. adding the appbar is ok, but does not have anything to do with > > adding ios support (that change is only a single line FWICT) > > > > also refactoring is also always good, but having those commits > > separate makes it much more easy to see what is actually changed. > > > > aside from that, there are a few comments inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel