From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 71E021FF165 for ; Thu, 14 Aug 2025 09:52:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6D496B4B2; Thu, 14 Aug 2025 09:54:30 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 14 Aug 2025 09:54:27 +0200 Message-Id: From: "Shan Shaji" To: "Dominik Csapak" , "Proxmox VE development discussion" X-Mailer: aerc 0.14.0 References: <20250813082937.22142-1-s.shaji@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755158034124 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.200 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v3] ui: enable noVNC console on iOS X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thank you so much for the review. I am using the samne versions flutter 3.29 and dart 3.7.2. I will create another patch without the formating changes to better identify the changes. After the patch is applied i can send another patch by runnning the `dart format .` command on master. On Wed Aug 13, 2025 at 3:36 PM CEST, Dominik Csapak wrote: > > > On 8/13/25 10:29, Shan Shaji wrote: > > The noVNC console was disabled in iOS and was only available in > > android. > > > > To fix the issue enabled the noVNC console view on iOS devices. The > > changes also includes a refactor of the function responsible for > > displaying the webview. Additionally, an `AppBar` has been added > > to the console view on to allow users to easily close the view. To > > avoid the body of the Scaffold to resize when the keyboard pops up set > > `resizeToAvoidBottomInset` [0] to `false` > > > > The `dart format` command was also ran in the file to fix the file > > formatting. > > is it possible to send dart format patches upfront and as a seperate patch? > > that way one can see the actual changes much more easily. > > also which version of dart/flutter do you use? > when i do `dart format` on that file here on current master, > it does not change the formatting at all > (but i'm still on flutter 3.29 with dart sdk on 3.7.2) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel